Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kick old node 12, 13; add newer node 16 #494

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Kick old node 12, 13; add newer node 16 #494

merged 1 commit into from
Feb 17, 2023

Conversation

leemyongpakvn
Copy link
Contributor

Questions Answers
Description? Kick too old Node 12, Node 13; Add newer Node 16
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Issue, please write "Fixes #[issue number]" here.
How to test? run npm install && npm run build in Node 14, then Node 16 to make sure there is no error happens.

@leemyongpakvn leemyongpakvn reopened this Jan 29, 2023
@leemyongpakvn leemyongpakvn reopened this Jan 30, 2023
@leemyongpakvn leemyongpakvn reopened this Jan 31, 2023
kpodemski
kpodemski approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go 🎉

@kpodemski kpodemski added this to the 5.1.2 milestone Feb 17, 2023
@kpodemski kpodemski merged commit 114360e into PrestaShop:dev Feb 17, 2023
@kpodemski
Copy link
Contributor

thanks @leemyongpakvn !

@leemyongpakvn leemyongpakvn deleted the patch-1 branch February 24, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpodemski kpodemski kpodemski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@leemyongpakvn @kpodemski