Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper category front_office_features #490

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Use proper category front_office_features #490

merged 1 commit into from
Jan 13, 2023

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Jan 12, 2023

Questions Answers
Description? This module should be in front_office_features category as all other frontend modules. There is no reason this module should be listed in seo category. Also, as this is a native classic theme module, it will be listed in in Theme modules section anyway.
Type? bug fix
BC breaks?
Deprecations?
Fixed ticket?
How to test?

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Jan 13, 2023

Ping @kpodemski for approval & merge 😎

@kpodemski kpodemski added this to the 5.1.2 milestone Jan 13, 2023
@kpodemski kpodemski merged commit e51ba46 into dev Jan 13, 2023
@matks matks deleted the Hlavtox-patch-1 branch October 2, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpodemski kpodemski kpodemski approved these changes

@0x346e3730 0x346e3730 0x346e3730 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Hlavtox @kpodemski @0x346e3730