Fix: non-svg custom icon is hidden in FO after editing in BO

[leemyongpakvn]

Problem:
In first Upload and Save, the custom icon is stored in custom_icon column AdminBlockListingController.php#L167-L204
In later Edit and Save, the custom icon moved to icon column AdminBlockListingController.php#L146-L163
So following displayBlockProduct.tpl#L24-L30, a non-svg custom icon is showed after first Save, then is hidden after later Save.

Questions	Answers
Description?	Solution: Predefined svg icon and Custom uploaded icon must be saved in icon and custom_icon column respectively, based on icon source.
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/PrestaShop/issues/29134
How to test?	Please follow the related issue's Steps to reproduce before PR and after PR

[NeOMakinG]

🍬

[NeOMakinG]

@leemyongpakvn on 🔥 these days

[matks]

@leemyongpakvn I agree with @NeOMakinG : you're doing a wonderful job

[leemyongpakvn]

@NeOMakinG We need some rain these days 💦

[florine2623]

Hello @leemyongpakvn ,

Tested on 1.7.8.x and 8.0.x.

Tested with svg and non-svg icons. Icons are always available.

I am encountering an error when I add non-svg icon, I install the PR, and then I check my FO.

Here's what I have in my database :

In my BO, the previously added image is not displayed, here's what I have:

If I deactivated my block, there's no more error.

[leemyongpakvn]

when I add non-svg icon, I install the PR, and then I check my FO

In theory: my PR only impact the FO once you Edit and Save a block in BO. Just apply the PR won't break anything.
So please try to edit an exiting block or add a new block after apply PR, then check the FO.
And make sure that you use a fresh install of blockreassurance 5.1.1 to test, I'm afraid that you have applied many PRs during your QA work.

[leemyongpakvn]

@florine2623 FYI the error you described above is similar to a 3 months-old issue PrestaShop/PrestaShop/issues/28264

[florine2623]

Hello @leemyongpakvn ,

Tested again with fresh install 1.7.8.7 and 8.0.x + installation of your PR on v5.1.1.

Tested non-svg and svg icons and checked in BO and FO if the display was correct.
Edited the icon multiple time via Modify icon or via or upload file and tested with svg, jpg, png and gif.
Checked multilanguage if the icons were uploaded.

It is looking good! Icons are always kept in FO if not edited.

It is QA ✅
Thans!

[ghost]

Thank you @leemyongpakvn && @florine2623