[LOGS] Improve zip error logs #1078
Open
+22
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
M0rgan01
commented
Dec 10, 2024
M0rgan01
commented
| Questions | Answers |
|---|---|
| Description? | Improve zip error logs |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | - |
| Sponsor company | - |
| How to test? | - |
|
Proposal for improving error logs during zip actions |
M0rgan01
force-pushed
the
Improve-zip-error-log
branch
from
5831b25 to
0fa2630
Compare
classes/ZipAction.php
Outdated
| $this->logger->error( | ||
| $this->translator->trans( | ||
| 'Could not extract %file% from backup, the destination might not be writable.', | ||
| ['%file%' => $zip->statIndex($i)['name']] | ||
| 'Could not extract %file%: %error%', |
There was a problem hiding this comment.
Suggested change
| 'Could not extract %file%: %error%', | |
| 'Could not extract %file% from archive: %error%', |
classes/ZipAction.php
Outdated
| throw new ZipActionException('Unable to open zipFile ' . $zipFile); | ||
| $error = $zip->getStatusString(); | ||
|
|
||
| $this->logger->error($this->translator->trans('Unable to open zipFile %s: %s', [$zipFile, $error])); |
There was a problem hiding this comment.
Suggested change
| $this->logger->error($this->translator->trans('Unable to open zipFile %s: %s', [$zipFile, $error])); | |
| $this->logger->error($this->translator->trans('Unable to open archive %s: %s', [$zipFile, $error])); |
classes/ZipAction.php
Outdated
| $error = $zip->getStatusString(); | ||
|
|
||
| $this->logger->error($this->translator->trans('Unable to open zipFile %s: %s', [$zipFile, $error])); | ||
| throw new ZipActionException('Unable to open zipFile ' . $zipFile . ': ' . $error); |
There was a problem hiding this comment.
Suggested change
| throw new ZipActionException('Unable to open zipFile ' . $zipFile . ': ' . $error); | |
| throw new ZipActionException('Unable to open archive ' . $zipFile . ': ' . $error); |
M0rgan01
force-pushed
the
Improve-zip-error-log
branch
from
0fa2630 to
5d3dd1c
Compare
|
ga-devfront
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.