Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate category images #1060

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Migrate category images #1060

merged 3 commits into from
Dec 18, 2024

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Dec 3, 2024

Questions Answers
Description? Autoupgrade PR for PrestaShop/PrestaShop#36877
Type?
BC breaks? no
Deprecations? no
Fixed ticket?
Sponsor company
How to test?

@Quetzacoalt91
Copy link
Member

Hi Daniel, I think you may aim for the dev branch as this where we have all the changes for PrestaShop 9. If in the future we need them on the 6.x branch, we will manage all the back-porting.

@Hlavtox Hlavtox changed the base branch from 6.x to dev December 3, 2024 12:15
@Hlavtox Hlavtox modified the milestones: 6.3.0, 7.0.0 Dec 3, 2024
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Dec 3, 2024

@Quetzacoalt91 Hi, understood, rebased, branch changed. :-)

M0rgan01
M0rgan01 previously approved these changes Dec 6, 2024
@kpodemski
Copy link
Contributor

kpodemski commented Dec 7, 2024

@Hlavtox you didn’t import the DbWrapper class correctly

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Dec 10, 2024

@kpodemski All green now

@AureRita
Copy link
Contributor

Hi @Hlavtox

Can you resolve your conflict ? it seems to be here because of the validation of your previous PR.

Waiting for feedback

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Dec 17, 2024

@AureRita Ready to go. :-)

Ping @ShaiMagal for reapproval

@AureRita
Copy link
Contributor

AureRita commented Dec 18, 2024

Hi @Hlavtox

Thank you for your PR, I tested it and I see that different things works :

if we only have a cover, we'll have a thumbnail

recording.29.webm

if we only have a thumbnail, it 'll delete the small part of them

recording.28.webm

and if we have both of them, the small part will be deleted

recording.27.webm

but we can also see that it doesn't delete " Menu thumbnails ". Did you want to delete them in this PR on in another one ?

Except this part, for me it can be a QA ✔️

Tested on :
8.0.4 to 8.2.0
8.0.4 to 9.0.0
8.2.0 to 9.0.0

Waiting for feedback

@Hlavtox Hlavtox merged commit d2cead5 into PrestaShop:dev Dec 18, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants