-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate category images #1060
Migrate category images #1060
Conversation
Hlavtox
commented
Dec 3, 2024
Questions | Answers |
---|---|
Description? | Autoupgrade PR for PrestaShop/PrestaShop#36877 |
Type? | |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | |
Sponsor company | |
How to test? |
Hi Daniel, I think you may aim for the |
@Quetzacoalt91 Hi, understood, rebased, branch changed. :-) |
@Hlavtox you didn’t import the DbWrapper class correctly |
@kpodemski All green now |
Hi @Hlavtox Can you resolve your conflict ? it seems to be here because of the validation of your previous PR. Waiting for feedback |
@AureRita Ready to go. :-) Ping @ShaiMagal for reapproval |
|
Hi @Hlavtox Thank you for your PR, I tested it and I see that different things works : if we only have a cover, we'll have a thumbnail recording.29.webmif we only have a thumbnail, it 'll delete the small part of them recording.28.webmand if we have both of them, the small part will be deleted recording.27.webmbut we can also see that it doesn't delete " Menu thumbnails ". Did you want to delete them in this PR on in another one ? Except this part, for me it can be a QA ✔️ Tested on : Waiting for feedback |