deduplicating Inputs
#16785
Draft
deduplicating Inputs
#16785
+88
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #16785 will not alter performanceComparing Summary
|
a14e
reviewed
Jan 20, 2025
src/prefect/cache_policies.py
Outdated
| raise TypeError("Can only subtract strings from key policies.") | ||
|
|
||
| # Subtract from each sub-policy; this may stack new Inputs(...) layers | ||
| new_subpolicies: list[CachePolicy] = [p - other for p in self.policies] |
There was a problem hiding this comment.
@zzstoatzz
p - other can create a new CompoundCachePolicy with nested Inputs.
This can cause unintended layering of Inputs within CompoundCachePolicy.
You might need to recursively update the exclude field for nested Inputs as well.
Perhaps at this level, it would make sense to also unpack all nested CompoundCachePolicy objects?
Co-authored-by: nate nowack <[email protected]>
zzstoatzz
force-pushed
the
redundant-inputs
branch
from
6a8cfc6 to
52961f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #16773