Skip to content

[UI v2] feat: Add AutomationsDeleteDialog #16595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Jan 3, 2025

Adds AutomationsDeleteDialog

Screenshot 2025-01-03 at 10 32 59 AM

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Jan 3, 2025
@@ -58,7 +58,7 @@ export const GlobalConcurrencyLimitsDeleteDialog = ({
</DialogTrigger>
<Button
variant="destructive"
onClick={() => handleOnClick(limit?.id)}
onClick={() => handleOnClick(limit.id)}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes this typing. In a previous PR, typings got fixed such that id is required

@devinvillarosa devinvillarosa force-pushed the add-delete-automation-dialog branch from 8950bf8 to df02445 Compare January 3, 2025 19:20
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devinvillarosa devinvillarosa merged commit 45fc50f into main Jan 3, 2025
8 checks passed
@devinvillarosa devinvillarosa deleted the add-delete-automation-dialog branch January 3, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants