Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix k8s guide to avoid suggesting you need cloud #14040

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Fix k8s guide to avoid suggesting you need cloud #14040

merged 4 commits into from
Jun 14, 2024

Conversation

zzstoatzz
Copy link
Collaborator

No description provided.

@zzstoatzz zzstoatzz added docs fix A fix for a bug in an existing feature labels Jun 14, 2024
@zzstoatzz zzstoatzz marked this pull request as ready for review June 14, 2024 19:43
@zzstoatzz zzstoatzz requested a review from a team as a code owner June 14, 2024 19:43
jamiezieziula
jamiezieziula reviewed Jun 14, 2024
View reviewed changes
docs/2.19.x/how-to-guides/work-pools/kubernetes.mdx Outdated
```
worker:
serverApiConfig:
apiUrl: <dns or ip address of your Prefect Server instance>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this should be invented one

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in indent

Abdur-rahmaanJ
Abdur-rahmaanJ approved these changes Jun 14, 2024
View reviewed changes
Copy link

@Abdur-rahmaanJ Abdur-rahmaanJ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now super clear that we can also self-host.

Maybe for folks used to the project it's clear, but i scouted here and there the whole day and i could not find out another way than prefect cloud.

Because even the official blogs use prefect cloud when deploying.

@zzstoatzz zzstoatzz merged commit 069b153 into main Jun 14, 2024
4 checks passed
@zzstoatzz zzstoatzz deleted the fix-cloud-insinuation branch June 14, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abdur-rahmaanJ Abdur-rahmaanJ Abdur-rahmaanJ approved these changes

@jamiezieziula jamiezieziula jamiezieziula approved these changes

Assignees
No one assigned
Labels
docs fix A fix for a bug in an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zzstoatzz @jamiezieziula @Abdur-rahmaanJ