ft: adds GH option to ignore cache upload failures#11869
Merged
urimandujano merged 2 commits intomainfrom Feb 5, 2024
Merged
Conversation
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chrisguidry
approved these changes
Feb 5, 2024
Collaborator
chrisguidry
left a comment
There was a problem hiding this comment.
That's good thinking!
Contributor
Author
|
I'm going to go ahead and merge this because:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've seen a lot of failures attempting to upload our built images to the GithubActions Cache API. This PR updates our build and upload step to ignore failures resulting from cache uploads. This should let the CI continue without using cached images. The idea here is its better for the CI run to continue without a cached image than it is to crash if we can't cache anymore.
Reference PRs:
Example
Checklist
<link to issue>"maintenance,fix,feature,enhancement,docs.For documentation changes:
netlify.tomlfor files that are removed or renamed.For new functions or classes in the Python SDK:
mkdocs.ymlnavigation.