Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap pytest-asyncio #11319

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Cap pytest-asyncio #11319

merged 1 commit into from
Dec 4, 2023

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Dec 4, 2023

pytest-asyncio introduced a change in 0.23.0 to prevent overriding the event loop in tests. We override the event loop to use async fixtures with session and module scopes. The solution for event loop scoping doesn't account for fixtures, so we'll need to cap pytest-asyncio for now. See pytest-dev/pytest-asyncio#706 for more details.

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in netlify.toml for files that are removed or renamed

@desertaxle desertaxle requested a review from a team as a code owner December 4, 2023 17:57
Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit e626f08
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/656e12f6110f5000071169e7
😎 Deploy Preview https://deploy-preview-11319--prefect-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@desertaxle desertaxle added the development Tech debt, refactors, CI, tests, and other related work. label Dec 4, 2023
@desertaxle desertaxle merged commit 1466087 into main Dec 4, 2023
56 checks passed
@desertaxle desertaxle deleted the cap-pytest-asyncio branch December 4, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants