Enhancement: Progress Artifact #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-graphs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dylanbhughes
changed the title
pleek91
approved these changes
May 22, 2024
Comment on lines
+16
to
+17
| type: ArtifactType, | ||
| } & RunGraphArtifactTypeAndData |
There was a problem hiding this comment.
Since type exists on RunGraphArtifactTypeAndData It be little more readable and simpler to do this
{
selected?: boolean,
name?: string,
artifact: RunGraphArtifactTypeAndData
}Then you can just do options.artifact.type everywhere.
6 tasks
pleek91
reviewed
May 22, 2024
Comment on lines
+194
to
+195
| artifactCacheKey && settings.disableArtifacts, | ||
| artifactCacheKey, |
There was a problem hiding this comment.
Probably not hurting anything but I think this is what we want here.
Suggested change
| artifactCacheKey && settings.disableArtifacts, | |
| artifactCacheKey, | |
| artifactCacheKey && settings.disableArtifacts, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds handling for displaying dynamic progress artifacts on the flow run graph.