You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds a Claude Code skill that codifies how to interact with the chatgpt-codex-connector bot that reviews PRs in this repo. The skill covers checking whether Codex has reviewed the latest commit, evaluating its P0/P1/P2 comments, replying to dismissed comments with reasoning (so the maintainer can see the decision), and the correct gh api incantation for replying to review comments.
Born from a session where we iterated through several review cycles and learned the patterns the hard way.
Summary: The Tests with lowest-direct dependencies CI job failed due to an ImportError in the anthropic sampling handler — unrelated to changes in this PR.
Root Cause: src/fastmcp/client/sampling/handlers/anthropic.py imports Base64ImageSourceParam from anthropic.types, but this symbol was introduced in anthropic>=0.48.0. The current minimum version in pyproject.toml is anthropic>=0.40.0, so the lowest-deps job installs 0.40.0 which doesn't have it.
Suggested Solution: This is already being addressed by PR #3553, which bumps the anthropic optional dependency floor from 0.40.0 to 0.48.0 in pyproject.toml. No changes are needed in this PR.
Detailed Analysis
Failing job: Tests with lowest-direct dependencies (Job ID 67636576467)
Error log excerpt:
ERROR collecting tests/client/sampling/handlers/test_anthropic_handler.py
ImportError while importing test module '...test_anthropic_handler.py'.
E ImportError: cannot import name 'Base64ImageSourceParam' from 'anthropic.types'
E ImportError: The `anthropic` package is not installed. Install it with `pip install fastmcp[anthropic]`
Root code (src/fastmcp/client/sampling/handlers/anthropic.py, line 26):
Base64ImageSourceParam was introduced in PR #3550 (image/audio sampling handler). PR #3553 fixes the version floor.
Related Files
src/fastmcp/client/sampling/handlers/anthropic.py — imports Base64ImageSourceParam at line 26, uses it at line 64
pyproject.toml — defines anthropic>=0.40.0 as the minimum version (needs to be >=0.48.0)
tests/client/sampling/handlers/test_anthropic_handler.py — test file that fails to collect due to the import error
ℹ️ This PR (#3552) makes no changes to the anthropic handler — the failure is pre-existing and tracked in PR #3553.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enhancementImprovement to existing functionality. For issues and smaller PR improvements.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Claude Code skill that codifies how to interact with the
chatgpt-codex-connectorbot that reviews PRs in this repo. The skill covers checking whether Codex has reviewed the latest commit, evaluating its P0/P1/P2 comments, replying to dismissed comments with reasoning (so the maintainer can see the decision), and the correctgh apiincantation for replying to review comments.Born from a session where we iterated through several review cycles and learned the patterns the hard way.