Skip to content

Add review-pr skill for Codex bot workflow#3552

Merged
jlowin merged 1 commit intomainfrom
chore/review-pr-skill
Mar 18, 2026
Merged

Add review-pr skill for Codex bot workflow#3552
jlowin merged 1 commit intomainfrom
chore/review-pr-skill

Conversation

@jlowin
Copy link
Copy Markdown
Member

@jlowin jlowin commented Mar 18, 2026

Adds a Claude Code skill that codifies how to interact with the chatgpt-codex-connector bot that reviews PRs in this repo. The skill covers checking whether Codex has reviewed the latest commit, evaluating its P0/P1/P2 comments, replying to dismissed comments with reasoning (so the maintainer can see the decision), and the correct gh api incantation for replying to review comments.

Born from a session where we iterated through several review cycles and learned the patterns the hard way.

@marvin-context-protocol marvin-context-protocol Bot added the enhancement Improvement to existing functionality. For issues and smaller PR improvements. label Mar 18, 2026
@jlowin jlowin merged commit ff20c56 into main Mar 18, 2026
7 of 8 checks passed
@jlowin jlowin deleted the chore/review-pr-skill branch March 18, 2026 19:30
@marvin-context-protocol
Copy link
Copy Markdown
Contributor

Test Failure Analysis

Summary: The Tests with lowest-direct dependencies CI job failed due to an ImportError in the anthropic sampling handler — unrelated to changes in this PR.

Root Cause: src/fastmcp/client/sampling/handlers/anthropic.py imports Base64ImageSourceParam from anthropic.types, but this symbol was introduced in anthropic>=0.48.0. The current minimum version in pyproject.toml is anthropic>=0.40.0, so the lowest-deps job installs 0.40.0 which doesn't have it.

Suggested Solution: This is already being addressed by PR #3553, which bumps the anthropic optional dependency floor from 0.40.0 to 0.48.0 in pyproject.toml. No changes are needed in this PR.

Detailed Analysis

Failing job: Tests with lowest-direct dependencies (Job ID 67636576467)

Error log excerpt:

ERROR collecting tests/client/sampling/handlers/test_anthropic_handler.py
ImportError while importing test module '...test_anthropic_handler.py'.
E   ImportError: cannot import name 'Base64ImageSourceParam' from 'anthropic.types'
E   ImportError: The `anthropic` package is not installed. Install it with `pip install fastmcp[anthropic]`

Root code (src/fastmcp/client/sampling/handlers/anthropic.py, line 26):

from anthropic.types import (
    ...
    Base64ImageSourceParam,  # Added in anthropic 0.48.0
    ...
)

pyproject.toml currently specifies:

anthropic = ["anthropic>=0.40.0"]

Base64ImageSourceParam was introduced in PR #3550 (image/audio sampling handler). PR #3553 fixes the version floor.

Related Files
  • src/fastmcp/client/sampling/handlers/anthropic.py — imports Base64ImageSourceParam at line 26, uses it at line 64
  • pyproject.toml — defines anthropic>=0.40.0 as the minimum version (needs to be >=0.48.0)
  • tests/client/sampling/handlers/test_anthropic_handler.py — test file that fails to collect due to the import error

ℹ️ This PR (#3552) makes no changes to the anthropic handler — the failure is pre-existing and tracked in PR #3553.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement to existing functionality. For issues and smaller PR improvements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant