Update repository references for transfer to prefecthq#3207
Conversation
📝 WalkthroughWalkthroughThis PR updates all repository references from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
marvin-context-protocol
Bot
added
the
enhancement
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/v2/servers/tools.mdx (1)
160-169:⚠️ Potential issue | 🟡 Minor"Using the Decorator" code block is missing
import timeThe second
CodeGrouptab callstime.sleep(5)but never importstime. Additionally,make_async_backgroundis used without any indication that it comes from the first tab, which could confuse readers who copy only this snippet.📝 Proposed fix
from fastmcp import FastMCP +import time +from your_module import make_async_background # defined in the Decorator Recipe tab above mcp = FastMCP() `@mcp.tool`() `@make_async_background` def my_tool() -> None: time.sleep(5)As per coding guidelines: "Code examples in documentation must explain before showing code and include all necessary imports for full runnable blocks."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/v2/servers/tools.mdx` around lines 160 - 169, The code example in the "Using the Decorator" snippet is missing necessary imports: add "import time" and explicitly import or reference make_async_background so the snippet is runnable and self-contained (e.g., import make_async_background from its module or show it comes from the first tab); ensure the top of the snippet includes "from fastmcp import FastMCP" plus the import for make_async_background (or a comment indicating its origin) so my_tool, mcp.tool(), make_async_background, and time.sleep are all defined in the snippet.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/patterns/contrib.mdx`:
- Line 15: Replace the broken GitHub link target in the docs text that points to
"https://github.com/prefecthq/fastmcp/tree/main/src/fastmcp/contrib" (the
"contrib directory" link) with the correct repository URL
"https://github.com/jlowin/fastmcp/tree/main/src/fastmcp/contrib" so the link
resolves; if you prefer to wait for a transfer, leave a TODO comment in the same
line indicating the link should be updated to prefecthq/fastmcp once the
transfer is complete.
In `@docs/v2/community/showcase.mdx`:
- Line 50: The GitHub Discussions links in docs/v2/community/showcase.mdx were
changed to prefectorhq/fastmcp but that repo transfer hasn't happened yet;
revert the two updated URLs back to the current jlowin/fastmcp/discussions (or
guard them with a TODO comment) so the links remain valid until the transfer is
complete—specifically update the markdown link target(s) that currently point to
https://github.com/prefecthq/fastmcp/discussions back to
https://github.com/jlowin/fastmcp/discussions (these are the link occurrences on
the lines referenced in the diff).
---
Outside diff comments:
In `@docs/v2/servers/tools.mdx`:
- Around line 160-169: The code example in the "Using the Decorator" snippet is
missing necessary imports: add "import time" and explicitly import or reference
make_async_background so the snippet is runnable and self-contained (e.g.,
import make_async_background from its module or show it comes from the first
tab); ensure the top of the snippet includes "from fastmcp import FastMCP" plus
the import for make_async_background (or a comment indicating its origin) so
my_tool, mcp.tool(), make_async_background, and time.sleep are all defined in
the snippet.
| Contrib modules provide additional features, integrations, or patterns that complement the core FastMCP library. They offer a way for the community to share useful extensions while keeping the core library focused and maintainable. | ||
|
|
||
| The available modules can be viewed in the [contrib directory](https://github.com/jlowin/fastmcp/tree/main/src/fastmcp/contrib). | ||
| The available modules can be viewed in the [contrib directory](https://github.com/prefecthq/fastmcp/tree/main/src/fastmcp/contrib). |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
prefecthq/fastmcp GitHub repository
💡 Result:
PrefectHQ/fastmcp is not an active GitHub repository (the URL returns 404 Not Found). [1]
The FastMCP project is available here instead:
jlowin/fastmcp(FastMCP v2, Python framework for building MCP servers/clients) [2]
Related PrefectHQ repos you may be looking for:
PrefectHQ/prefect-mcp-server(Prefect’s MCP server) [3]PrefectHQ/fastmcp-quickstart-template(FastMCP quickstart example template) [4]
Sources: [1] [2] [3] [4]
Update the GitHub link to point to the correct FastMCP repository.
The link to prefecthq/fastmcp returns 404 — this repository does not exist. The FastMCP project is available at jlowin/fastmcp instead. Either update the link to the correct repository or wait for the actual transfer to prefecthq/fastmcp to complete before merging.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/patterns/contrib.mdx` at line 15, Replace the broken GitHub link target
in the docs text that points to
"https://github.com/prefecthq/fastmcp/tree/main/src/fastmcp/contrib" (the
"contrib directory" link) with the correct repository URL
"https://github.com/jlowin/fastmcp/tree/main/src/fastmcp/contrib" so the link
resolves; if you prefer to wait for a transfer, leave a TODO comment in the same
line indicating the link should be updated to prefecthq/fastmcp once the
transfer is complete.
| ### Community Examples | ||
|
|
||
| Have you built something interesting with FastMCP? We'd love to feature high-quality examples here! Start a [discussion on GitHub](https://github.com/jlowin/fastmcp/discussions) to share your project. | ||
| Have you built something interesting with FastMCP? We'd love to feature high-quality examples here! Start a [discussion on GitHub](https://github.com/prefecthq/fastmcp/discussions) to share your project. |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
GitHub repository prefecthq/fastmcp discussions
💡 Result:
There doesn’t appear to be a prefecthq/fastmcp repository with GitHub Discussions. The FastMCP repo (made by Prefect) is hosted as jlowin/fastmcp, and its Discussions are here: https://github.com/jlowin/fastmcp/discussions. [1][2]
If you meant Prefect’s org Discussions instead, Prefect’s main repo Discussions are here: https://github.com/prefecthq/prefect/discussions. [3]
Sources:
[1] https://github.com/jlowin/fastmcp/discussions
[2] https://github.com/jlowin/fastmcp
[3] https://github.com/prefecthq/prefect/discussions
Do not merge these changes until the repository transfer to prefecthq/fastmcp is complete.
Lines 50 and 59 update the GitHub Discussions URLs to https://github.com/prefecthq/fastmcp/discussions, but this repository does not currently exist. The FastMCP repository is still at jlowin/fastmcp. Merging these changes will create broken links for users. Either defer these URL changes until after the transfer is finalized, or keep the links pointing to jlowin/fastmcp/discussions for now.
Also applies to: 59-59
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@docs/v2/community/showcase.mdx` at line 50, The GitHub Discussions links in
docs/v2/community/showcase.mdx were changed to prefectorhq/fastmcp but that repo
transfer hasn't happened yet; revert the two updated URLs back to the current
jlowin/fastmcp/discussions (or guard them with a TODO comment) so the links
remain valid until the transfer is complete—specifically update the markdown
link target(s) that currently point to
https://github.com/prefecthq/fastmcp/discussions back to
https://github.com/jlowin/fastmcp/discussions (these are the link occurrences on
the lines referenced in the diff).
Test Failure AnalysisSummary: Integration test is failing with a 404 error because it's trying to access , which doesn't exist yet. Root Cause: The test was updated to use Suggested Solution: This is expected and the test will pass once the repository is transferred to . You have a couple of options:
The failure is cosmetic and doesn't indicate any code issues - it's simply a timing issue between updating the references and completing the actual repository transfer. Detailed AnalysisThe failing test at result = await streamable_http_client.call_tool(
"list_commits", {"owner": "prefecthq", "repo": "fastmcp"}
)This triggers a GitHub API request to: Which returns: The test was updated from Related Files
|
Test Failure AnalysisSummary: Integration test Root Cause: The test was updated to use Suggested Solution: This is expected and the test will pass once the repository is transferred to
The failure is cosmetic and doesn't indicate any code issues - it's simply a timing issue between updating the references and completing the actual repository transfer. Detailed AnalysisThe failing test at result = await streamable_http_client.call_tool(
"list_commits", {"owner": "prefecthq", "repo": "fastmcp"}
)This triggers a GitHub API request to: Which returns: The test was updated from Related Files
|
Test Failure AnalysisSummary: The test Root Cause: The test has a flaky assumption about the number of requests made during client operations. The test configures
However, the client can make additional if name not in tool_output_schemas:
await list_tools_fn() # Extra list_tools call!This makes the total request count unpredictable and timing-dependent, causing the test to be flaky. Suggested Solution:
The simplest fix is option 1 - increase Detailed AnalysisTest Failure LogThe test expects the 4th Code Location
Why This HappensThe client's tool output schema caching is lazy - it only fetches schemas when needed. Depending on timing and cache state, extra Related Files
|
1 participant
Preparing to transfer the repository from
jlowin/fastmcptoprefecthq/fastmcp. This updates all source-level references — URLs in pyproject.toml, docs, CI scripts, examples, tests, and error messages — to point to the new location.The
docs/python-sdk/files are auto-generated and will be updated by the bot when it runs against the new repo.References to
@jlowinas a contributor (changelog credits, etc.) are left as-is since those refer to the person, not the repo. The upgrade guide now notes the new repository home as part of the v3 release.Summary by CodeRabbit
Release Notes