docs: add v3.0.0rc1 features to v3-features tracking#3145
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d03ebf92a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| @mcp.tool() | ||
| async def my_tool( | ||
| token: AccessToken = CurrentAccessToken, |
There was a problem hiding this comment.
Call CurrentAccessToken() in token injection example
The new example passes CurrentAccessToken without invoking it, but dependency injection only resolves parameters whose defaults are Dependency instances, and CurrentAccessToken is a factory function that returns that instance (src/fastmcp/_vendor/docket_di/__init__.py and src/fastmcp/server/dependencies.py). If readers copy this snippet as-is, they will pass a plain function object as the default and token injection will not run.
Useful? React with 👍 / 👎.
| ): ... | ||
| ``` | ||
|
|
||
| For Azure/Entra, the new `fastmcp[azure]` extra adds `EntraOBOToken` and `MSALApp` dependencies that handle the On-Behalf-Of token exchange declaratively: |
There was a problem hiding this comment.
Remove nonexistent MSALApp dependency from rc1 notes
This release note says fastmcp[azure] adds an MSALApp dependency, but the Azure provider implementation only defines EntraOBOToken for this workflow (src/fastmcp/server/auth/providers/azure.py) and there is no MSALApp API to import in the repo. That makes the documented capability unusable for anyone trying to follow the rc1 notes.
Useful? React with 👍 / 👎.
WalkthroughIntroduces a new documentation section in docs/development/v3-notes/v3-features.mdx for version 3.0.0rc1. The content describes multiple concurrent tool execution, an OpenAPI validate_output option, Auth Token injection with Azure OBO, generate-cli agent skill generation, a background task queue, and a breaking rename from ui= to app=. All updates are narrative release-notes content with usage snippets and references. No source code or public API signatures are modified in this change. Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/development/v3-notes/v3-features.mdx (1)
1-3:⚠️ Potential issue | 🟡 MinorFrontmatter is missing the required
descriptionfield.As per coding guidelines: "Every MDX documentation page must begin with YAML frontmatter containing title and description."
Proposed fix
--- title: v3.0 Feature Tracking +description: Tracks major features across FastMCP v3.0 pre-release milestones for release notes preparation. ---
| ```python | ||
| result = await context.sample( | ||
| messages="Fetch weather for NYC and LA", | ||
| tools=[fetch_weather], | ||
| tool_concurrency=0, # Unlimited parallel execution | ||
| ) | ||
| ``` |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check how tool_concurrency is documented/validated in the source
rg -n -C3 'tool_concurrency' --type=pyRepository: jlowin/fastmcp
Length of output: 14020
🏁 Script executed:
cd docs/development/v3-notes && head -30 v3-features.mdxRepository: jlowin/fastmcp
Length of output: 1224
Add prose clarification for tool_concurrency=0 semantics.
The inline code comment is clear and correct, but per documentation guidelines, add explicit mention in the prose (before the code example) that tool_concurrency=0 enables unlimited parallel execution. This helps readers who scan the text without reading code comments.
Note: The codebase does not provide alternative constants (None, math.inf, etc.) for unlimited concurrency; 0 is the intentional API design.
Adds an RC1 section to v3-features.mdx covering PRs that landed between beta2 and rc1: concurrent tool execution in sampling (#3022),
validate_outputfor OpenAPI tools (#3134), auth token injection + Azure OBO dependencies (#2918),generate-cliSKILL.md generation (#3115), distributed background task notifications (#2906), and theui=→app=breaking rename (#3117).PRs #3086 and #3117 were already documented in the beta2 section so they're only cross-referenced here where relevant.