Conversation
Co-authored-by: Bill Easton <strawgate@users.noreply.github.com>
WalkthroughThis pull request updates documentation references in the FastMCP server middleware caching documentation to reflect new line numbers in the source file. Concurrently, in-code comments indicating expected typing fixes for PydanticAdapter generic aliases have been removed from the caching middleware implementation, along with associated type: ignore annotations on pydantic_model arguments. These changes reflect cleanup following the upgrade of the py-key-value-aio dependency, with no modifications to caching logic or public APIs. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Nice! |
Upgrades py-key-value-aio from 0.3.0 to 0.4.0, taking advantage of improved type annotations in PydanticAdapter.
The v0.4.0 release fixes type signature issues with generic aliases, allowing us to remove 6
type: ignore[arg-type]comments from the caching middleware. All tests pass and no breaking changes were encountered.Closes #3052
Generated with Claude Code