Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/martian-issue-triage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ jobs:
martian-issue-triage:
# For labeled events, verify the labeler is a repo member to prevent privilege escalation
if: |
(github.event.action == 'opened' && contains(fromJSON('["strawgate", "jlowin"]'), github.actor)) ||
(github.event.action == 'opened' && github.actor == 'strawgate') ||
(github.event.action == 'opened' && github.actor == 'jlowin' && contains(github.event.issue.labels.*.name, 'bug')) ||
(github.event.action == 'labeled' && github.event.label.name == 'triage-martian' && contains(fromJSON('["OWNER", "MEMBER", "COLLABORATOR"]'), github.event.sender.author_association))
Comment on lines +11 to 13
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Trigger triage when bug label is added later

As written, the job only runs for opened events where the bug label is already present. If jlowin opens an issue without the label and it’s applied later by a labeler or maintainer (a common workflow), the labeled event won’t trigger triage because it only checks for triage-martian. That means legitimate bug issues opened by jlowin will skip triage entirely unless the label is set at creation. Consider handling the labeled event for bug as well if the intent is “triage whenever a jlowin issue has a bug label.”

Useful? React with 👍 / 👎.


concurrency:
Expand Down
Loading