You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request removes inline type: ignore comments from method signatures across multiple modules and refactors the add_to_docket method declarations. Changes include updating method signatures to use keyword-only parameters for fn_key, task_key, and **kwargs in prompts, tools, and resource template classes. Additionally, task registry assignments in the client are modified, and cursor extraction logic in server functions is simplified. The overall behavioral semantics remain unchanged.
Use CreateTaskResult for background task creation #2660: Updates the same SEP-1686 task helper functions in src/fastmcp/client/client.py with changes to _read_resource_as_task, _get_prompt_as_task, and _call_tool_as_task.
Fix ty 0.0.5 type errors #2676: Coordinates typing and signature edits across the same modules including function prompt, resource template, and tool implementations.
The title 'Bump dependencies' is vague and does not accurately reflect the actual changes, which involve removing type: ignore annotations and updating method signatures across multiple files.
Revise the title to describe the actual changes, such as 'Remove type: ignore annotations and update method signatures' or check if this is the correct PR.
Description check
⚠️ Warning
The pull request description is entirely empty, missing all required sections from the template including description, issue reference, and checklists.
Add a comprehensive description following the template, including what changes were made, which issue is being closed, and completed checklist items.
✅ Passed checks (1 passed)
Check name
Status
Explanation
Docstring Coverage
✅ Passed
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependenciesUpdates to project dependencies. Automatically applied to dependabot PRs.ignore in release notesMinor change for release notes. Use sparingly for meta PRs like workflow tests.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.