-
Notifications
You must be signed in to change notification settings - Fork 2k
Refactor FastMCP to inherit from Provider #2901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
85f3295
Refactor FastMCP to inherit from Provider
jlowin 66d713b
Merge main into refactor-provider-inheritance-v2
jlowin d3ae0ed
Fix transform application and update tests for None return values
jlowin 6ba5e5d
Fix type errors and add type ignore comments
jlowin ddd2058
Merge remote-tracking branch 'origin/main' into refactor-provider-inh…
jlowin 5ade5a4
Simplify Provider transform architecture
jlowin 5b24ea3
Refactor FastMCP to use inherited _get_* methods from Provider
jlowin 78ab933
Fix transform application in FastMCPProvider and MCP handlers
jlowin 6dd1de6
Address PR review feedback
jlowin 3d98862
Fix auth test to expect None instead of AuthorizationError
jlowin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that
_transformsno longer includesVisibility, any code that still iteratesself._transformsdirectly will skip visibility filtering.FastMCPProvider.get_tasks()still wraps onlyself._transforms, so provider-level enable/disable (or allowlist) won’t be applied to task registration for mounted servers, and disabled components can still be registered with Docket. This regression is introduced by separating visibility from_transforms; updateFastMCPProvider.get_tasks()to iterateself.transformsinstead (seesrc/fastmcp/server/providers/fastmcp_provider.py).Useful? React with 👍 / 👎.