Update CLI banner with FastMCP 3.0 notice#2765
Conversation
|
Warning Rate limit exceeded@jlowin has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 38 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe changes simplify server banner logging by removing transport-specific parameters from the Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/fastmcp/utilities/cli.py (1)
216-218: Remove commented-out code.The commented-out docs row should be removed entirely rather than left as a comment. The docs URL is now displayed separately in the panel content (line 221).
🔎 Proposed fix
info_table.add_row("🖥", "Server:", Text(server.name, style="dim")) - # info_table.add_row("📚", "Docs:", "https://gofastmcp.com") info_table.add_row("🚀", "Deploy free:", "https://fastmcp.cloud")Based on coding guidelines: "Unused code (dead code, commented-out code, debug artifacts)" should be removed.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/fastmcp/server/server.pysrc/fastmcp/utilities/cli.py
🧰 Additional context used
📓 Path-based instructions (1)
src/fastmcp/**/*.py
📄 CodeRabbit inference engine (AGENTS.md)
src/fastmcp/**/*.py: Python ≥ 3.10 with full type annotations required
Prioritize readable, understandable code - clarity over cleverness. Avoid obfuscated or confusing patterns even if shorter
Follow existing patterns and maintain consistency in code implementation
Be intentional about re-exports - don't blindly re-export everything to parent namespaces. Core types defining a module's purpose should be exported. Specialized features can live in submodules. Only re-export to fastmcp.* for most fundamental types
Never use bare except - be specific with exception types
Files:
src/fastmcp/server/server.pysrc/fastmcp/utilities/cli.py
🧠 Learnings (1)
📚 Learning: 2025-12-25T15:53:07.646Z
Learnt from: CR
Repo: jlowin/fastmcp PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-25T15:53:07.646Z
Learning: Applies to tests/**/*.py : Pass FastMCP servers directly to clients for testing without network complexity; only use HTTP transport when explicitly testing network features
Applied to files:
src/fastmcp/server/server.py
🧬 Code graph analysis (1)
src/fastmcp/server/server.py (1)
src/fastmcp/utilities/cli.py (1)
log_server_banner(200-255)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Run tests: Python 3.10 on windows-latest
- GitHub Check: Run tests: Python 3.13 on ubuntu-latest
- GitHub Check: Run tests: Python 3.10 on ubuntu-latest
- GitHub Check: Run tests with lowest-direct dependencies
🔇 Additional comments (5)
src/fastmcp/server/server.py (2)
2498-2499: LGTM!The banner call has been correctly simplified to match the new signature in
cli.py. The transport information is no longer displayed in the banner, which aligns with the PR objective to show a static v3 notice instead of dynamic transport details.
2563-2564: LGTM!The banner call has been correctly simplified to match the new signature. The transport, host, port, and path details are no longer passed to the banner function, which now displays a static layout with the v3 notice.
src/fastmcp/utilities/cli.py (3)
6-6: LGTM!The function signature has been correctly simplified to accept only the server parameter, removing transport-specific details. The
Literalimport is also no longer needed and has been appropriately removed.Also applies to: 200-201
221-243: LGTM!The addition of the v3 notice panel is well-implemented and provides clear guidance to users about pinning their FastMCP version in production. The docs URL has been elegantly moved to a separate centered text element in the main panel, maintaining good visual hierarchy.
254-255: LGTM!The centered rendering of both panels together will provide a clean, professional appearance in the CLI output. The Group wrapping ensures proper spacing with newlines before and after.
Updating CLI with 3.0 message.