-
Notifications
You must be signed in to change notification settings - Fork 2.1k
SEP-1577: Sampling with tools #2551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 15 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
84f1736
MCP → SDK (vocab change only)
jlowin 5fb9103
WIP: Sampling API with SamplingResult[T] and result_type
jlowin 0d8679c
SEP-1577: Sampling with tools
jlowin ead4730
Fix tool result content handling in OpenAI handler
jlowin 5c0f055
Remove @sampling_tool decorator - pass functions directly to sample()
jlowin b544cdd
Merge main into sampling-tools-sep-1577
jlowin 1cf947b
Merge main into sampling-tools-sep-1577
github-actions[bot] 4b5bfe6
Remove auto-conversion of MCP tools to sampling tools
jlowin 1d7c1da
Merge branch 'main' into sampling-tools-sep-1577
jlowin 7796179
Merge branch 'main' into sampling-tools-sep-1577
jlowin 2cdc9b6
Refactor sampling API: replace sample_iter() with sample_step()
jlowin 5e6c790
Address CodeRabbit nitpicks
jlowin 1ef5319
Address CodeRabbit review feedback for sampling tools
jlowin b079fe5
Address additional CodeRabbit review feedback
jlowin 07df7c6
Review fixes for sampling tools PR
jlowin 1bba6e0
Fix OpenAI handler tests to use AsyncOpenAI
jlowin 6bc676e
Merge branch 'main' into sampling-tools-sep-1577
jlowin 5629f24
Address remaining CodeRabbit review comments
jlowin 0d9272e
Add return type annotation to OpenAISamplingHandler.__init__
jlowin 2c63948
Use explicit 'is not None' check for sampling_capabilities defaulting
jlowin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify what “SamplingCapability()” disables (tools only vs sampling entirely).
The comment says “No tool support”, but
SamplingCapability()reads like “no sampling features at all”. Consider showingSamplingCapability(tools=None)(or the exact “no-tools” shape) and stating what remains enabled.🤖 Prompt for AI Agents