Add a proxy pass directive for nebula so we can avoid CORS issues #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@elucid does a user need to be authed to hit this endpoint?
if the answer is no, there may be a security issue with exposing Coach Assistant data to the world
|
This is fine locally, but for prod can we not just setup CORS? Ideally I'd like to have less services proxying through es nginx. I know we did this for wedge, but at the time we agreed it was a hacky, non-ideal solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jonhunt-pn we are doing this so that we can make requests to nebula app from space-roost without running into CORS issues. we will need a corresponding PR for the terraform stuff