Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move config file to standard location #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move config file to standard location #18

wants to merge 1 commit into from

Conversation

ghedamat
Copy link
Collaborator

@ghedamat ghedamat commented Nov 9, 2019 •
edited by typeoneerror
Loading

the comfy crate uses the directories crate to automatically
position the config file in the standard place

https://docs.rs/directories/2.0.2/directories/struct.ProjectDirs.html

this IS a breaking change but allows us to reduce code and follow
conventions

closes #9 and #6

@ghedamat
Move config file to standard location
5a4618b 
the `comfy` crate uses the `directories` crate to automatically
position the config file in the standard place

https://docs.rs/directories/2.0.2/directories/struct.ProjectDirs.html

this IS a breaking change but allows us to reduce code and follow
conventions
@ghedamat ghedamat removed their assignment Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typeoneerror typeoneerror typeoneerror left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pndev toml file also creates a .pndev_config directory and it should not
2 participants
@ghedamat @typeoneerror