Skip to content

feat(landing): waitlist-only access; hide sign-in surfaces - #1

Merged
Pranav-Bobde merged 1 commit into
mainfrom
staging
Jul 27, 2026
Merged

feat(landing): waitlist-only access; hide sign-in surfaces#1
Pranav-Bobde merged 1 commit into
mainfrom
staging

Conversation

@Pranav-Bobde

@Pranav-Bobde Pranav-Bobde commented Jul 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • add advisory CodeQL scanning for JavaScript and TypeScript
  • run on pushes to staging/main and pull requests targeting main
  • keep branch protection unchanged

Verification

  • prior full repository verification passed
  • staged diff contained only .github/workflows/codeql.yml

This draft PR is for advisory CodeQL and CodeRabbit verification only. Do not merge yet.

Summary by CodeRabbit

  • Chores
    • Added automated CodeQL security scanning for JavaScript and TypeScript code changes.
    • Scans run for updates targeting the main and staging branches.

@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
better-mail Ready Ready Preview, Comment Jul 27, 2026 9:02am

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a GitHub Actions CodeQL workflow that scans JavaScript and TypeScript on pushes and pull requests targeting main and staging.

Changes

CodeQL security scanning

Layer / File(s) Summary
CodeQL analysis workflow
.github/workflows/codeql.yml
Configures repository permissions, triggers, checkout, CodeQL initialization for JavaScript and TypeScript, and CodeQL analysis execution.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes landing-page access changes, but the PR adds a CodeQL scanning workflow. Rename it to reflect the workflow change, e.g. 'Add CodeQL analysis workflow for JavaScript and TypeScript'.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch staging

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Pranav-Bobde

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/codeql.yml:
- Around line 26-27: Update the actions/checkout@v4 step in the CodeQL workflow
to set persist-credentials to false, ensuring checkout does not retain
authentication credentials for subsequent steps.
- Around line 26-27: Update the checkout step in the CodeQL workflow from
actions/checkout@v4 to actions/checkout@v5, preserving the existing step
configuration.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6461fb59-e86c-4b42-b2db-6c170283892e

📥 Commits

Reviewing files that changed from the base of the PR and between e9e8747 and f9854d0.

📒 Files selected for processing (1)
  • .github/workflows/codeql.yml

Comment thread .github/workflows/codeql.yml Outdated
@Pranav-Bobde

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Pre-launch the product is waitlist-only, so the landing page should not
offer a way in. Every sign-in surface now points at the waitlist, and
/login bounces to / behind a single SIGN_IN_ENABLED flag.

- nav, hero, bento tile, CTA band and both footer links -> #waitlist
- CTA band renders the real WaitlistForm (source="landing-cta")
- drop the now-unused GoogleCta/GoogleIcon from landing-kit
- retarget in-app /login redirects (sign-out, OAuth error) at /

Scope: this is a UI gate, not a security boundary. /api/auth/* stays
reachable, which keeps owner-driven staging e2e working. Flip
SIGN_IN_ENABLED to re-open sign-in.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@Pranav-Bobde Pranav-Bobde changed the title ci: add CodeQL analysis workflow feat(landing): waitlist-only access; hide sign-in surfaces Jul 27, 2026
@Pranav-Bobde
Pranav-Bobde merged commit f994f30 into main Jul 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants