Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Client Rename Provider Settings #4950

Closed
wants to merge 20 commits into from
Closed

Implement Client Rename Provider Settings #4950

wants to merge 20 commits into from

Commits on Sep 12, 2024

  1. registering new rename provider feature

    @Razmo99 @JustinGrote
    Razmo99 authored and JustinGrote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b02df6f View commit details
    Browse the repository at this point in the history

  2. hints for dispose

    @Razmo99 @JustinGrote
    Razmo99 authored and JustinGrote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d26601e View commit details
    Browse the repository at this point in the history

  3. implemented prepar rename symbol

    @Razmo99 @JustinGrote
    Razmo99 authored and JustinGrote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d533c2b View commit details
    Browse the repository at this point in the history

  4. added more detection and handeling for preparerenamesymbol

    @Razmo99 @JustinGrote
    Razmo99 authored and JustinGrote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    056cb4b View commit details
    Browse the repository at this point in the history

  5. removed substring to avoid confusion

    @Razmo99 @JustinGrote
    Razmo99 authored and JustinGrote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    1c1a38e View commit details
    Browse the repository at this point in the history

  6. updating rename sumbol to new languageclient format

    @Razmo99 @JustinGrote
    Razmo99 authored and JustinGrote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e56a794 View commit details
    Browse the repository at this point in the history

  7. removed command register and not implemented method

    @Razmo99 @JustinGrote
    Razmo99 authored and JustinGrote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6ee4eb5 View commit details
    Browse the repository at this point in the history

  8. implemented renamesymbol as a feature and structured under languageCl… 

    …ientConsumers
    @Razmo99 @JustinGrote
    Razmo99 authored and JustinGrote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6a27fd8 View commit details
    Browse the repository at this point in the history

  9. added logging. Now using forof. throw instead of promise.reject. remo… 

    …ved unused exports
    @Razmo99 @JustinGrote
    Razmo99 authored and JustinGrote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6f28123 View commit details
    Browse the repository at this point in the history

  10. adjusting unhandled error preifx

    @Razmo99 @JustinGrote
    Razmo99 authored and JustinGrote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    9245c93 View commit details
    Browse the repository at this point in the history

  11. added new option to specifiy if an Alias should be generated when a f… 

    …unction parameter is renamed
    @Razmo99 @JustinGrote
    Razmo99 authored and JustinGrote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a48c88e View commit details
    Browse the repository at this point in the history

  12. renaming ShouldGenerateAlias to create CreateAlias

    @Razmo99 @JustinGrote
    Razmo99 authored and JustinGrote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    0b497f6 View commit details
    Browse the repository at this point in the history

  13. Move RenameSymbolSettings to RenameSymbol.ts 

    I know this differs from the existing style of the codebase but it makes sense to keep the separation of concerns local. Ideally PartialSettings is also updated to a stricter type like Record<String, Object> or something.
    @JustinGrote
    JustinGrote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    4a2196c View commit details
    Browse the repository at this point in the history

  14. Revert Settings, I was wrong and created a circular dependency, oops

    @JustinGrote
    JustinGrote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8b3b660 View commit details
    Browse the repository at this point in the history

  15. Add Rename Disclaimer. Fully detailed disclaimer to come next

    @JustinGrote
    JustinGrote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    df907ec View commit details
    Browse the repository at this point in the history

  16. Add First-Run rename disclaimer

    @JustinGrote
    JustinGrote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    81e2e99 View commit details
    Browse the repository at this point in the history

  17. Refresh config when fetching after update

    @JustinGrote
    JustinGrote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8e456e1 View commit details
    Browse the repository at this point in the history

  18. Refine format to use Unicode

    @JustinGrote
    JustinGrote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    76ba1dd View commit details
    Browse the repository at this point in the history

  19. Add note about unsaved files

    @JustinGrote
    JustinGrote committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    fb60faf View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Adjusted VScode renameSymbol requests arguments to support new LSP fr… 

    …amework
    @Razmo99
    Razmo99 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    627ec9b View commit details
    Browse the repository at this point in the history