Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog and files for 1.7.0 release #1287

Merged
merged 3 commits into from
Apr 25, 2018

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Apr 25, 2018

Updates the CHANGELOG in preparation for the 1.7.0 release.

@rjmholt rjmholt changed the title Update changelog for 1.7.0 release Update changelog and files for 1.7.0 release Apr 25, 2018
CHANGELOG.md Outdated
Add a community snippet for date-annotated `Write-Verbose` messages.

- [PowerShell/vscode-powershell #1228](https://github.com/PowerShell/vscode-powershell/issues/1228) -
Make comment-based help trigger customizable (between `##`, `<#` and disabled).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is a little misleading. My take is this:

Make comment-based help trigger always be ## with a new setting powershell.helpCompletion to allow you to select between help comment styles: BlockComment (default) or LineComment. You can also specify Disabled to disable this functionality.

CHANGELOG.md Outdated
Fix PowerShell crashing on machines with IPv6 disabled.

- [PowerShell/vscode-powershell #1243](https://github.com/PowerShell/vscode-powershell/issues/1243) -
Support custom PowerShell executable paths in user and workspace configurations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording tweak if possible:

Support custom PowerShell executable paths in user configuration which can be selected (via name) in either user or workspace configuration.

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on Keith's comments. Otherwise LGTM!

@rjmholt
Copy link
Contributor Author

rjmholt commented Apr 25, 2018

@rkeithhill Thanks for your help -- wasn't really sure what I was looking at in a couple of those.

Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants