Skip to content

Added SupportsWildcards attribute to New-ExternalHelp -Path. #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Added SupportsWildcards attribute to New-ExternalHelp -Path. #227

wants to merge 2 commits into from

Conversation

@juneb
Copy link

@juneb juneb commented Oct 31, 2016 •
edited by SteveL-MSFT
Loading

To make this work, you will have to update/regenerate the .md files for that function.

This change is Reviewable

@juneb
Added SupportsWildcards attribute to New-ExternalHelp -Path. To make …
16a1e6f 
…this work, you will have to update/regenerate the .md files for that function.
@msftclas
Copy link

msftclas commented Oct 31, 2016

Hi @juneb, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@vors
Copy link
Collaborator

vors commented Nov 2, 2016

Thank you, @juneb
Failures seems unrelated. https://ci.appveyor.com/project/PowerShell/markdown-maml/build/0.7.1.876#L487

vors
vors reviewed Nov 2, 2016
View reviewed changes
src/platyPS/platyPS.psm1 Outdated
Position=1,
ValueFromPipeline=$true,
ValueFromPipelineByPropertyName=$true)]
ValueFromPipelineByPropertyName = $true)]
Copy link
Collaborator

@vors vors Nov 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line seems off. Is it because of mixing spaces and tabs?

@vors vors added this to the 0.8.0 milestone Dec 21, 2016
@adityapatwardhan
Copy link
Member

adityapatwardhan commented Jun 17, 2017

@vors Is this ready to merge?

@vors
Copy link
Collaborator

vors commented Jun 17, 2017 •
edited
Loading

@adityapatwardhan there are other places that needs to updates as well. I started that at vors/wildcards-docs and didn't merge it yet, because found that Update-MarkdownHelp didn't pick up changes after I made them. Lets hold this open for reminder, but I will probably ending up merging it from vors/wildcards-docs

vors
vors suggested changes Jun 17, 2017
View reviewed changes
Copy link
Collaborator

@vors vors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other places in the file with the $Path that should get the same update.

@vors
Copy link
Collaborator

vors commented Jun 18, 2017

Suppressed by #281

@vors vors closed this Jun 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vors vors vors requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@juneb @msftclas @vors @adityapatwardhan