-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Administrators group is not enforced in non en-us system #488
Administrators group is not enforced in non en-us system #488
Conversation
@bagajjal Not clear how this fits into other changes, but isn't the "Administrators" group name (hardcoded in this change) also localized based on operating system? |
@NoMoreFood - This fix is to handle the configuration in sshd_config . Default sshd_config has the following configuration.. Currently for non english OS flavors this check fails as "administrators" account is not present but instead a localized name of "administrators" .. LookupAccountNameW() fails. Now we explicitly compare for "administrators" and return the WinBuiltinAdministratorsSid. fyi, This is already fixed as a windows security update. |
PowerShell/Win32-OpenSSH#1757