Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Administrators group is not enforced in non en-us system #488

Merged
merged 21 commits into from
Mar 25, 2021

Conversation

bagajjal
Copy link

bagajjal and others added 21 commits October 14, 2019 13:03
@bagajjal bagajjal merged commit 54824dd into PowerShell:latestw_all Mar 25, 2021
@NoMoreFood
Copy link

@bagajjal Not clear how this fits into other changes, but isn't the "Administrators" group name (hardcoded in this change) also localized based on operating system?

@bagajjal
Copy link
Author

bagajjal commented Mar 25, 2021

@NoMoreFood - This fix is to handle the configuration in sshd_config .

Default sshd_config has the following configuration..
Match Group administrators
AuthorizedKeysFile PROGRAMDATA/ssh/administrators_authorized_keys

Currently for non english OS flavors this check fails as "administrators" account is not present but instead a localized name of "administrators" .. LookupAccountNameW() fails. Now we explicitly compare for "administrators" and return the WinBuiltinAdministratorsSid.

fyi, This is already fixed as a windows security update.

@bagajjal bagajjal changed the title Administrator non en-us OS. Administrators group is not enforced in non en-us system Mar 26, 2021
@bagajjal bagajjal deleted the administrator_non_en_us branch April 11, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants