Add support for AuthorizedKeysCommand and AuthorizedPrincipalsCommand to run as System #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to run as System Add support for AuthorizedKeysCommand and AuthorizedPrincipalsCommand to run as System. - When sshd is run as system and provided username is system, run command as subprocess using posix_spawnp - Improve debug logging in spawn_child_internal by providing different logging message for when CreateProcessW and CreateProcessAsUserW are called. This is part 2 of the a 2 part PR to Fix issue #1546
bagajjal
reviewed
Mar 11, 2021
bagajjal
reviewed
Mar 11, 2021
|
Please resolve the conflicts in the auth.c file. |
- Added the needed includes, guarded by Windows ifdef. - Added boolean variable to store determination with default of false. - Moved evaluation into Windows only section since we're using SID comparison. - Changed from string evaluation of "system" to comparing the SID of the user with WinLocalSystemSid.
bagajjal
reviewed
Mar 17, 2021
Consolidating changes to be in one part of the file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for AuthorizedKeysCommand and AuthorizedPrincipalsCommand to run as System.
This is part 2 of the a 2 part PR to Fix issue #1546