Fix issue where # in path causes the path to resolve incorrectly #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
requested review from
TylerLeonhardt,
rkeithhill and
SeeminglyScience
|
Our current testing means we can't test this stuff cross platform btw -- I can't create a file URI with a |
|
Still not sure what's causing PowerShell/vscode-powershell#1513 -- I can't reproduce it (even on a Mac) |
TylerLeonhardt
approved these changes
Sep 20, 2018
| @@ -11,6 +11,10 @@ | |||
| using System.Security; | |||
| using System.Text; | |||
|
|
|||
| #if CoreCLR | |||
| using System.Runtime.InteropServices; | |||
There was a problem hiding this comment.
Is this used anywhere else? If not, maybe get rid of this ifdef and use the full name space below?
There was a problem hiding this comment.
Only used in the one line, but twice. We would need the full namespace on both RuntimeInformation.IsOSPlatform() and OSPlatform.Windows.
I just tried it, and I think the import is less cumbersome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PowerShell/vscode-powershell#1518 in a second way!
We seemed to be double escaping URIs. I've changed the behaviour and added a battery of tests around
Workspace.ResolveFilePath()(that we should add to).Now a URI like
file:///C:/foo/bar#x/baz/will resolve toC:\foo\bar#x\baz\and notC:\foo\bar.