Skip to content

Fix #315: Log an error message for unhandled request and event types #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2016
Merged

Fix #315: Log an error message for unhandled request and event types #316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/PowerShellEditorServices.Protocol/MessageProtocol/MessageDispatcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,7 @@ protected async Task DispatchMessage(
else
{
// TODO: Message not supported error
Logger.Write(LogLevel.Error, $"MessageDispatcher: No handler registered for Request type '{messageToDispatch.Method}'");
}
}
else if (messageToDispatch.MessageType == MessageType.Response)
Expand All @@ -297,11 +298,13 @@ protected async Task DispatchMessage(
else
{
// TODO: Message not supported error
Logger.Write(LogLevel.Error, $"MessageDispatcher: No handler registered for Event type '{messageToDispatch.Method}'");
}
}
else
{
// TODO: Return message not supported
Logger.Write(LogLevel.Error, $"MessageDispatcher received unknown message type of method '{messageToDispatch.Method}'");
}

if (handlerToAwait != null)
Expand Down