Skip to content

Instead of using the first cimClass and then having no superClass, use the first cimClass that has a non-null superClass #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bergmeister merged 2 commits into from
May 5, 2019
Merged

Instead of using the first cimClass and then having no superClass, use the first cimClass that has a non-null superClass #1200

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
061451f
Instead of using the first cimClass and then having to superClass, us…
bergmeister Mar 28, 2019
05f3349
add regression test
bergmeister May 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Rules/UseIdenticalMandatoryParametersDSC.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ private IDictionary<string, string> GetKeys(string fileName)
// todo log the error
}

var cimClass = cimClasses?.FirstOrDefault();
var cimClass = cimClasses?.FirstOrDefault(_cimClass => _cimClass.CimSuperClass != null);
var cimSuperClassProperties = new HashSet<string>(
cimClass?.CimSuperClass?.CimClassProperties.Select(cimPropertyDeclaration => cimPropertyDeclaration.Name) ??
Enumerable.Empty<string>());
Expand Down