Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Link GroupPolicyDsc resource #478

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

corydwood
Copy link

@corydwood corydwood commented Jan 15, 2019

Closes #101

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • This PR changes documentation
  • This PR changes DscResource.Template
    • Updated documentation as necessary in the TEMPLATE_README.md.
    • An descriptive entry has been added to the change log
      in the TEMPLATE_README.md.
  • This PR changes Tests.Template
    • The template version number has been increased appropriately.
    • An descriptive entry has been added to the CHANGELOG.md under the
      Tests.Template folder.

This change is Reviewable

New resource module submission

Name: GroupPolicyDsc

Repository URL: https://github.com/corydwood/GroupPolicyDsc

Short description: This module contains the GPInheritance, GPOImport, and GPOLink DSC resources.

New resource module submission task list

This task list can be filled in after the issue has been submitted.

  • [] Pass the Quality Governance
  • Pull request is sent in (see next section).
  • The new module submission in ready for community review.

Steps that pull request should include

  • Added submodule using git submodule add https://github.com/<accountname>/<reponame> DscResources/<reponame>.
  • Updated resource module list in Maintainers.md.

Community acceptance

Community reviewers: Please submit a comment on the issue for each box that are checked so the
community know who accepted the item.

The new resource module:

  • is licensed under MIT.
  • has the correct project structure.
  • has a dev and master branch, and dev should default branch.
  • is using DSC Resource Kit test templates.
  • is connected to Codecov or similar.
  • has established a code of conduct in ether a CODE_OF_CONDUCT.md or a
    'Code of conduct' section in the README.md.
  • has either a CONTRIBUTING.md file or a 'Contributing' section in the
    README.md file.
  • has included the metadata tag 'DSCResource' in the module manifest.
  • is sufficiently documented.
  • has an established CI process for each push to the repository.
  • is sufficiently tested.
  • Follows the guidelines set out for a
    High Quality Resource Module.

Submission acceptance

The community accepts, at a community call, that a resource module follows the
guidelines set out for a
High Quality Resource Module.

  • The resource module was accepted for submission in a community call.

Copy link
Contributor

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @corydwood)

a discussion (no related file):
Please see the steps here:
https://github.com/PowerShell/DscResources/issues/new?template=New_resource_module_submission.md

If you could paste that into the PR description, then we can follow that list? 🙂



.gitmodules, line 196 at r1 (raw file):

	path = DscResources/WmiNamespaceSecurityDsc
	url = https://github.com/PowerShell/WmiNamespaceSecurityDsc
[submodule "DscResources/GroupPolicyDsc"]

This should have been added using git submodule add https://github.com/<accountname>/<reponame> DscResources/<reponame>, then I think there will also be a reference to module as part of the commit.

Copy link
Author

@corydwood corydwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @johlju)

a discussion (no related file):

Previously, johlju (Johan Ljunggren) wrote…

Please see the steps here:
https://github.com/PowerShell/DscResources/issues/new?template=New_resource_module_submission.md

If you could paste that into the PR description, then we can follow that list? 🙂

Done.



.gitmodules, line 196 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

This should have been added using git submodule add https://github.com/<accountname>/<reponame> DscResources/<reponame>, then I think there will also be a reference to module as part of the commit.

Done.

Copy link
Contributor

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @corydwood)

a discussion (no related file):
Could you please tick off the boxes that is done in the list of the PR description?


a discussion (no related file):
Would it be possible to add the appveyor.yml template? It will use the DscResource.Test test framework when running tests, and helps tests things for HQRM (not everything, but some). https://github.com/PowerShell/DscResources/blob/master/DscResource.Template/appveyor.yml


a discussion (no related file):
Do you have aplan for deploying this module to the PS Gallery? I can't see it being deployed yet.


@johlju
Copy link
Contributor

johlju commented Feb 3, 2019

I of course meant with the review comment if your repo can change to the appveyor.yml template 😄

@stale
Copy link

stale bot commented Feb 17, 2019

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

@stale stale bot added the abandoned The pull request has been abandoned. label Feb 17, 2019
@gaelcolas gaelcolas added in progress The issue is being actively worked on by someone. new module submission A request that the community evaluate a resource module for submission into the DSC Resource Kit. waiting for author response The pull request is waiting for the author to respond to comments in the pull request. and removed abandoned The pull request has been abandoned. labels Mar 13, 2019
@gaelcolas
Copy link
Contributor

Disabled the Stale bot and changed the labels.
Also talked to Cory who'll get back to this as soon as he can.

@gaelcolas
Copy link
Contributor

I have permission on the repository, and I will see if I can get this resource in good shape for next Community call where we'll be able to reconsider this.

@gaelcolas gaelcolas added on hold The issue or pull request has been put on hold by a maintainer. and removed in progress The issue is being actively worked on by someone. waiting for author response The pull request is waiting for the author to respond to comments in the pull request. labels Jun 25, 2019
@gaelcolas
Copy link
Contributor

As announced during the last community call, we'd love to have this as part of dsccommunity.
@corydwood gave me permissions to the repo and I'll try to get this re-homed when we transfer to the new GitHub organisation in a few weeks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new module submission A request that the community evaluate a resource module for submission into the DSC Resource Kit. on hold The issue or pull request has been put on hold by a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New resource module: GroupPolicy
3 participants