Skip to content

Backport: progress json updates #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 26, 2025
Merged

Backport: progress json updates #660

merged 12 commits into from
Feb 26, 2025

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Feb 25, 2025

SteveL-MSFT and others added 12 commits February 25, 2025 13:42
@SteveL-MSFT
Fix progress display when using JSON, add None option; exhance progre…
92e72a8 
…ss schema
@SteveL-MSFT
fix tests
bfc7c8e
@SteveL-MSFT
address Tess' feedback moving common code to a function and adding co…
74b8a2c 
…mments to pub functions
@SteveL-MSFT
Fix ordering of setting progress data and writing it
3a6196e
@SteveL-MSFT @tgauth
Update dsc_lib/src/progress.rs
12ac4a6 
Co-authored-by: Tess Gauthier <[email protected]>
@SteveL-MSFT
encapsulate set_percent_complete() into write_json() since it's only …
cc86557 
…needed there
@SteveL-MSFT
Removed percentComplete and added totalItems and completedItems, add …
79be779 
…failed property to progress
@SteveL-MSFT
fix test
8a1a70a
@SteveL-MSFT
change to a failure object that contains exitCode and message
ac862bc
@SteveL-MSFT
fix clippy
eb1201a
@SteveL-MSFT
since every discovery function takes progress, move it to constructor
66dc9d9
@SteveL-MSFT
update lockfiles
13419d6
@SteveL-MSFT SteveL-MSFT added this to the 3.0-Approved milestone Feb 25, 2025
@SteveL-MSFT SteveL-MSFT merged commit e8e7cdc into PowerShell:v3.0.0 Feb 26, 2025
4 checks passed
@SteveL-MSFT SteveL-MSFT deleted the backport-progress-json branch February 26, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgauth tgauth tgauth approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0-Approved

Development

Successfully merging this pull request may close these issues.

2 participants

@SteveL-MSFT @tgauth