Skip to content

pre-allocate string for table writer #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2024
Merged

pre-allocate string for table writer #345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dsc/src/tablewriter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ impl Table {
let (width, _) = size().unwrap_or((80, 25));
// make header bright green
println!("\x1b[1;32m");
let mut header_row = String::new();
let mut header_row = String::with_capacity(width as usize);
let last_column = self.header.len() - 1;
for (i, column) in self.header.iter().enumerate() {
header_row.push_str(&format!("{:<width$}", column, width = self.column_widths[i]));
Expand All @@ -67,7 +67,7 @@ impl Table {

// TODO: make this smarter by splitting long text to multiple lines
for row in &self.rows {
let mut row_str = String::new();
let mut row_str = String::with_capacity(header_row.len());
for (i, column) in row.iter().enumerate() {
row_str.push_str(&format!("{:<width$}", column, width = self.column_widths[i]));
if i != last_column {
Expand Down