Skip to content

use tracing indicatif to sync tracing and progress bar rendering #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2024
Merged

use tracing indicatif to sync tracing and progress bar rendering #343

merged 1 commit into from
Mar 5, 2024

Conversation

@tgauth
Copy link
Collaborator

@tgauth tgauth commented Mar 4, 2024

PR Summary

PR Context

  • use tracing indicatif to sync tracing and progress bar rendering

@tgauth tgauth marked this pull request as ready for review March 4, 2024 21:52
@tgauth tgauth requested review from SteveL-MSFT and anmenaga March 4, 2024 21:52
SteveL-MSFT
SteveL-MSFT approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveL-MSFT SteveL-MSFT added this pull request to the merge queue Mar 5, 2024
Merged via the queue into PowerShell:main with commit 10a765b Mar 5, 2024
@tgauth tgauth deleted the update-tracing-subscriber-with-indicatif branch March 6, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tracing and progress get interleaved

2 participants

@tgauth @SteveL-MSFT