Skip to content

Conversation

Gijsreyn
Copy link
Contributor

@Gijsreyn Gijsreyn commented Oct 10, 2025

PR Summary

This pull request adds the uriComponent() and uriComponentToString() functions, along with their reference documentation.

PR Context

Partially addresses #57.

@Gijsreyn
Copy link
Contributor Author

Not sure what totally went wrong here, but the older build failed, while the new one succeeded at first.

@Gijsreyn Gijsreyn requested a review from SteveL-MSFT October 11, 2025 10:41
@Gijsreyn Gijsreyn changed the title Add uri(), uriComponent(), and uriComponentToString() functions Add uriComponent() and uriComponentToString() functions Oct 14, 2025
@Gijsreyn Gijsreyn requested a review from SteveL-MSFT October 14, 2025 17:49
@Gijsreyn Gijsreyn requested a review from SteveL-MSFT October 16, 2025 00:56
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gijsreyn if the purpose of commenting out tests is to run the tests faster, you can always run specific tests directly in VSCode or use Invoke-Pester which has a filter parameter to limit which tests in a file gets run.

@Gijsreyn
Copy link
Contributor Author

Gijsreyn commented Oct 16, 2025

@SteveL-MSFT - I might have known only the method on -TagFilter. What I know mostly do is comment out the launch.json, comment out the test, and put a breakpoint. I'll take a look at your suggestion next time.

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT - I might have known only the method on -TagFilter. What I know mostly do is comment out the launch.json, comment out the test, and put a breakpoint. I'll take a look at your suggestion next time.

Here's an example:

invoke-pester -Output Detailed ./dsc/tests/dsc_expressions.tests.ps1 -FullNameFilter '*Accessors work*'

@SteveL-MSFT SteveL-MSFT added this pull request to the merge queue Oct 16, 2025
Merged via the queue into PowerShell:main with commit 24d34b8 Oct 16, 2025
19 checks passed
@Gijsreyn Gijsreyn deleted the gh-57/main/add-uri-functions branch October 16, 2025 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants