Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to PS 7.2, net60, and Terminal.Gui 1.6 #153

Closed
wants to merge 38 commits into from

Conversation

tig
Copy link
Collaborator

@tig tig commented Jun 3, 2022

This PR updates the project to Powershell 7.2, net60, and Terminal.Gui 1.6.

This is in prep for some bug fixes to Out-ConsoleGridView.

  • In testing Terminal.Gui 1.6, I found a regression: -Filter usage caused a crash. I tracked this down to how OCGV was using the Label control and found the bug in Terminal.Gui: If Label is constructed with string.Empty it barfs (See Label: If created with 'string.Empty' in constructor, fails to render gui-cs/Terminal.Gui#1769). The workaround is to construct it with " ". In addition, since Terminal.Gui 1.0, the ability to show/hide controls was added enabling a simplification of the logic for when the filter text changes.

  • Fixes OCGV: Filter edit chops off first char of filter string passed on command line #151 (serendipitously)

  • Diables building of the Avalona based Out-GridView... because it is dependent on versions of ReactivUI that are not supported by net60 and in diving in to try to fix I found a rabbit hole. Since no work will be done on the Avalona PS GUI components I think it's ok to not build them anymore.

tig and others added 30 commits March 11, 2020 15:55
@tig tig marked this pull request as ready for review June 3, 2022 11:21
@andyleejordan
Copy link
Member

  • Diables building of the Avalona based Out-GridView... because it is dependent on versions of ReactivUI that are not supported by net60 and in diving in to try to fix I found a rabbit hole. Since no work will be done on the Avalona PS GUI components I think it's ok to not build them anymore.

Went down a similar rabbit hole yesterday. It seems...doable...but yeah a bit of a headache because of the change to lifetime management in the updates to Avalonia.

Since no work will be done on the Avalona PS GUI components I think it's ok to not build them anymore.

What do you mean by this exactly? It looked to me like the Out-GridView package was entirely dependent on it, but I really don't know this project at all.

1 similar comment
@andyleejordan
Copy link
Member

  • Diables building of the Avalona based Out-GridView... because it is dependent on versions of ReactivUI that are not supported by net60 and in diving in to try to fix I found a rabbit hole. Since no work will be done on the Avalona PS GUI components I think it's ok to not build them anymore.

Went down a similar rabbit hole yesterday. It seems...doable...but yeah a bit of a headache because of the change to lifetime management in the updates to Avalonia.

Since no work will be done on the Avalona PS GUI components I think it's ok to not build them anymore.

What do you mean by this exactly? It looked to me like the Out-GridView package was entirely dependent on it, but I really don't know this project at all.

@tig
Copy link
Collaborator Author

tig commented Jun 8, 2022

What do you mean by this exactly? It looked to me like the Out-GridView package was entirely dependent on it, but I really don't know this project at all.

out-gridview is the Avalonia-based package.

@andyleejordan
Copy link
Member

Heh, vs Out-ConsoleGridView emphasis on Console lol.

@andyleejordan
Copy link
Member

Ah, dang, can you make one more update? v1.7.1 just released: https://github.com/gui-cs/Terminal.Gui/releases/tag/v1.7.1

@tig
Copy link
Collaborator Author

tig commented Aug 3, 2022

I'm working on an update to this PR that updates to the latest Terminal.Gui.

@SteveL-MSFT already merged several fixes that I had in this PR separately, so this PR will change to just get the latest Terminal.Gui.

Separately, I would like to upgrade OCGV to use Terminal.Gui's TableView which did not exist when @TylerLeonhardt first wrote OCGV.

@SteveL-MSFT , what is your thinking on actually releasing a new GraphicalTools package? It would be awesome if you are willing to work on making that happen!

@andyleejordan
Copy link
Member

@tig We are planning on releasing a new package! I just need to get to it, it's on my list for Monday. It was on my list for last Monday's community day, but I had to take the day off.

@tig
Copy link
Collaborator Author

tig commented Aug 3, 2022

@tig We are planning on releasing a new package! I just need to get to it, it's on my list for Monday. It was on my list for last Monday's community day, but I had to take the day off.

Well damn, then I better get to work on the re-write! LOL.

Seriously, if you just release with the Terminal.Gui v1.7.1 update and the fix for #151 (which I'm not sure is actually fixed; will do so today) that'd be mucho awesome.

@andyleejordan
Copy link
Member

The unfortunate bit is that I think a lot of work needs to go into setting up more secure and compliant release pipelines. I.e. we cannot build it locally and upload that package as a release, we have to automate it. The good news is that I've done that for other projects in the past so I'm not wholly unfamiliar, the bad news is that it's still quite an arduous process.

@tig
Copy link
Collaborator Author

tig commented Aug 3, 2022

The unfortunate bit is that I think a lot of work needs to go into setting up more secure and compliant release pipelines. I.e. we cannot build it locally and upload that package as a release, we have to automate it. The good news is that I've done that for other projects in the past so I'm not wholly unfamiliar, the bad news is that it's still quite an arduous process.

I get it. I'll do everything I can to make it easy for you. Other than ensuring the PRs are good, how else can I help?

@tig
Copy link
Collaborator Author

tig commented Aug 3, 2022

Superseded by #161; closing.

@tig tig closed this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCGV: Filter edit chops off first char of filter string passed on command line
2 participants