Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Terminal.Gui 1.0 #141

Merged
merged 38 commits into from
Apr 29, 2021
Merged

Upgrade to Terminal.Gui 1.0 #141

merged 38 commits into from
Apr 29, 2021

Conversation

tig
Copy link
Collaborator

@tig tig commented Mar 9, 2021

Fixes #140

This PR uses Terminal.Gui v1.0.0-beta.8 which is a near-final RC of 1.0.

@TylerLeonhardt and others: Please pull this PR down and test!

I will update it to use Terminal.Gui 1.0 once it's in the bag.

tig and others added 28 commits March 11, 2020 15:55
@tig
Fixed PowerShell#58: Multi-line commands rendering wrong
6af1903
@tig
Fixed PowerShell#58 - Newlines in commands render incorrectly
a69373e
@tig
Added debug instructions to readme
f155262
@tig @TylerLeonhardt
Update src/Microsoft.PowerShell.ConsoleGuiTools/ConsoleGui.cs
440833e 
Co-Authored-By: Tyler James Leonhardt <[email protected]>
@tig
simplified stripping of newline/linefeed
dd2e765
@tig
Merge branch 'master' of tig:tig/GraphicalTools
e66f614
@tig
Merge branch 'master' of tig:PowerShell/GraphicalTools
ebcb92f
@tig
Merge branch 'master' of tig:PowerShell/GraphicalTools
dce01c8
@tig
Merge branch 'master' of tig:PowerShell/GraphicalTools
a2c0238
@tig
Merge branch 'master' of tig:PowerShell/GraphicalTools
2184386
@tig
Merge branch 'master' of tig:PowerShell/GraphicalTools
668c5c5
@tig
Merge branch 'master' of tig:tig/GraphicalTools
9d2c85a
@tig
Merge branch 'master' of tig:PowerShell/GraphicalTools
d15fb38
@tig
Merge branch 'master' of tig:tig/GraphicalTools into master
49b9559
@tig
Merge branch 'master' of tig:PowerShell/GraphicalTools into master
4175dc0
@tig
Merge branch 'master' of tig:PowerShell/GraphicalTools into master
53b1203
@tig
Merge branch 'master' of tig:PowerShell/GraphicalTools into master
941cef7
@tig
Merge branch 'master' of tig:PowerShell/GraphicalTools into master
06c8a1f
@tig
Merge branch 'master' of tig:PowerShell/GraphicalTools into master
869b578
@tig
Merge branch 'master' of tig:PowerShell/GraphicalTools into master
1137d7d
@tig
Merge branch 'master' of tig:PowerShell/GraphicalTools into master
e965afd
@tig
Merge branch 'master' of tig:PowerShell/GraphicalTools into master
4188094
@tig
Merge branch 'master' of tig:tig/GraphicalTools into master
797de5e
@tig
Merge branch 'master' of tig:PowerShell/GraphicalTools
be4bea2
@tig
Merge branch 'master' of tig:tig/GraphicalTools
85d8578
@tig
Merge branch 'master' of tig:PowerShell/GraphicalTools
a03fc9b
@tig
Merge branch 'master' of tig:PowerShell/GraphicalTools
7eb9189
@tig
Updated build deps and dealt with breaking change in api
806d974
This was referenced Mar 9, 2021
Closed
Closed
@tig
Copy link
Collaborator Author

tig commented Apr 1, 2021

I have updated this PR with the very latest (1.0.0-beta.11).

One more big bug to squash before 1.0 is in the can: gui-cs/Terminal.Gui#1060

tig and others added 8 commits April 27, 2021 13:39
@tig
updated to Terminal.Gui 1.0.0-rc.11
7a6965a
@TylerLeonhardt @tig
Update NuGet.config (PowerShell#130)
29a0d72
@TylerLeonhardt @tig
move to compliance repo (PowerShell#128)
7f801bd 
* move to compliance repo

* first attempt at release

* add stages

* move pool

* remove pkges task

* add variable group

* try copying files

* remove extra extract

* copy to signed dir

* change tsa name

* move to PowerShell@2

* use new syntax

* change path

* idk

* idk

* move to publish task

* try these agents

* ConsoleGuiTools asset.json

* try different directory

* stuff

* publish artifacts
@TylerLeonhardt @tig
disable mouse tracking when ocgv closes (PowerShell#135)
a91750e
@tig
Updated build deps and dealt with breaking change in api
869f688
@tig
updated to latest terminal.gui package
cd760a3
@tig
updated to Terminal.Gui 1.0.0-rc.11
ae01241
@tig
Merge branch 'fix_140_terminalgui_1.0' of tig:tig/GraphicalTools into…
97483a3 
… fix_140_terminalgui_1.0
@andyleejordan
Copy link
Member

@tig is there any particular testing I should do for this?

@tig
Copy link
Collaborator Author

tig commented Apr 28, 2021

@tig is there any particular testing I should do for this?

Yes, please!

  • Play with the various -OutputMode options with various inputs to ensure the right objects are returned.
  • Test on non-Windows platforms, esp Mac iTerm. Ensure glyps appear correctly.
  • On non-Windows platform ensure that the terminal is reset properly after ocgv returns

Thanks!!

@tig
Copy link
Collaborator Author

tig commented Apr 28, 2021

Woot!

Terminal.Gui 1.0 is OUT.

It would be awesome if the PowerShell team could now do a release of GraphicalTools so that OutConsoleGridView could be used with the latest & greatest. Who can I buy beers for to make that happen? ;-)

@SteveL-MSFT? @TylerLeonhardt (even though you moved on)? @andschwa?

Hugs all around.

@andyleejordan
Copy link
Member

@tig It's actually on my list to do...this week! There was another fix that landed which we wanted to release for as well, and it was "end of April" that I was going to do it by, so excellent timing! I'll test both out and do just one release 😄

@andyleejordan andyleejordan self-requested a review April 29, 2021 19:49
@andyleejordan
Copy link
Member

@tig is there any particular testing I should do for this?

Yes, please!

  • Play with the various -OutputMode options with various inputs to ensure the right objects are returned.
  • Test on non-Windows platforms, esp Mac iTerm. Ensure glyps appear correctly.
  • On non-Windows platform ensure that the terminal is reset properly after ocgv returns

Thanks!!

All three of these things working great on my macMini (with an M1). I had to modify what SDK it was built against to get it to build, but that was just temporary.

andyleejordan
andyleejordan approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks!

@andyleejordan andyleejordan merged commit 7a04c0e into PowerShell:master Apr 29, 2021
@tig tig deleted the fix_140_terminalgui_1.0 branch April 29, 2021 20:43
@tig tig mentioned this pull request Apr 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyleejordan andyleejordan andyleejordan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OCGV: Upgrade to use Terminal.Gui v1.0
3 participants
@tig @andyleejordan @TylerLeonhardt