Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update out-consolegridview to Terminal.Gui 89.4 #106

Merged
merged 18 commits into from
Sep 27, 2020

Conversation

tig
Copy link
Collaborator

@tig tig commented Sep 27, 2020

This PR updates ocgv to use the very latest Terminal.gui nuget package, 89.4.

0.89.4 is the release candidate for 0.90.

Note that the ocgv documentation in docs/Microsoft.PowerShell.ConsoleGuiTools/Out-ConsoleGridView.md is way out of date still.

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerLeonhardt
Copy link
Member

With this version, I think we can ship 🙂

@TylerLeonhardt
Copy link
Member

BTW, the cmdlet being out of date.... You just need to run PlatyPS. There's an Invoke Build task here that will generate it:

https://github.com/PowerShell/GraphicalTools/blob/master/GraphicalTools.build.ps1#L170

@tig
Copy link
Collaborator Author

tig commented Sep 27, 2020

BTW, the cmdlet being out of date.... You just need to run PlatyPS. There's an Invoke Build task here that will generate it:

https://github.com/PowerShell/GraphicalTools/blob/master/GraphicalTools.build.ps1#L170

Doing ./Build.ps1 BuildCmdletHelp did not update the docs/Out-ConsoleGridView.md as I expected from your comment. Did I misunderstand? Is there another step?

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Sep 27, 2020

First, import your newly built module, then run:

Invoke-Build BuildCmdletHelp -ModuleName Microsoft.PowerShell.ConsoleGuiTools

@TylerLeonhardt
Copy link
Member

Actually... That might only build the MAML... In any case, if you don't wanna fix the markdown, I can do it before we ship

@TylerLeonhardt
Copy link
Member

@tig all good to merge?

@tig
Copy link
Collaborator Author

tig commented Sep 27, 2020

@tig all good to merge?

Yessir.

@TylerLeonhardt TylerLeonhardt merged commit 4141604 into PowerShell:master Sep 27, 2020
@tig tig deleted the update_to_guics_89_4 branch September 27, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants