-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protocol support for Bedrock 1.16.0 #293
Conversation
…w-raknet � Conflicts: � src/main/java/cn/nukkit/level/generator/Flat.java � src/main/java/cn/nukkit/level/generator/Nether.java � src/main/java/cn/nukkit/level/generator/Normal.java
…kit into pr/new-raknet
Merge commits from master
* Implement end portal creation * Import Vector3
…stMC#1505) This should allow chunks to load if invalid blocks are contained within it.
At this point, there are no known issues with walls, please, test them, test all possible connections both on side and above, it's important because the chunks will be updated proactively only once, this means that if the wall don't behave perfectly now, the players will have to break and place the walls or cause block updates to them to fix missing or incorrect connections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I marked all tagging, testing and adjustments that I found while reviewing.
- [#293] `SetSpawnPositionPacket.spawnForce` is now unused and will be removed on `1.4.0.0-PN` | ||
- [#293] `TextPacket.TYPE_JSON` was renamed to `TYPE_OBJECT` and will be removed on `1.4.0.0-PN` | ||
- [#293] `riderInitiated` argument was added to the `EntityLink` constructor. The old constructor will be removed on `1.4.0.0-PN` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be updated
src/main/java/cn/nukkit/network/protocol/PlayerArmorDamagePacket.java
Outdated
Show resolved
Hide resolved
src/main/java/cn/nukkit/network/protocol/PlayerEnchantOptionsPacket.java
Outdated
Show resolved
Hide resolved
src/main/java/cn/nukkit/network/protocol/PositionTrackingDBClientRequestPacket.java
Outdated
Show resolved
Hide resolved
src/main/java/cn/nukkit/network/protocol/PositionTrackingDBServerBroadcastPacket.java
Outdated
Show resolved
Hide resolved
src/main/java/cn/nukkit/network/protocol/UpdatePlayerGameTypePacket.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
# Conflicts: # src/main/java/cn/nukkit/Server.java # src/main/java/cn/nukkit/network/Network.java # src/main/java/cn/nukkit/network/RakNetInterface.java
According to GamePedia, quartz_bricks is 559. Leaving 41 free to allow expansion and custom blocks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks fine
This PR will add protocol support to the current version of PowerNukkit.
Currently tracking NukkitX#1507
This is a child task of #290 and solves #291