Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol support for Bedrock 1.16.0 #293

Merged
merged 158 commits into from
Jul 1, 2020
Merged

Protocol support for Bedrock 1.16.0 #293

merged 158 commits into from
Jul 1, 2020

Conversation

joserobjr
Copy link
Member

@joserobjr joserobjr commented Jun 25, 2020

This PR will add protocol support to the current version of PowerNukkit.

Currently tracking NukkitX#1507

This is a child task of #290 and solves #291

SupremeMortal and others added 30 commits February 1, 2020 14:46
…w-raknet

� Conflicts:
�	src/main/java/cn/nukkit/level/generator/Flat.java
�	src/main/java/cn/nukkit/level/generator/Nether.java
�	src/main/java/cn/nukkit/level/generator/Normal.java
* Implement end portal creation

* Import Vector3
…stMC#1505)

This should allow chunks to load if invalid blocks are contained within it.
@joserobjr
Copy link
Member Author

At this point, there are no known issues with walls, please, test them, test all possible connections both on side and above, it's important because the chunks will be updated proactively only once, this means that if the wall don't behave perfectly now, the players will have to break and place the walls or cause block updates to them to fix missing or incorrect connections.

Copy link
Member Author

@joserobjr joserobjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked all tagging, testing and adjustments that I found while reviewing.

- [#293] `SetSpawnPositionPacket.spawnForce` is now unused and will be removed on `1.4.0.0-PN`
- [#293] `TextPacket.TYPE_JSON` was renamed to `TYPE_OBJECT` and will be removed on `1.4.0.0-PN`
- [#293] `riderInitiated` argument was added to the `EntityLink` constructor. The old constructor will be removed on `1.4.0.0-PN`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be updated

src/main/java/cn/nukkit/api/PowerNukkitDifference.java Outdated Show resolved Hide resolved
src/main/java/cn/nukkit/Player.java Show resolved Hide resolved
src/main/java/cn/nukkit/block/BlockAnvil.java Outdated Show resolved Hide resolved
src/main/java/cn/nukkit/block/BlockEndPortalFrame.java Outdated Show resolved Hide resolved
@IWareQ

This comment has been minimized.

IWareQ and others added 5 commits July 1, 2020 00:23
# Conflicts:
#	src/main/java/cn/nukkit/Server.java
#	src/main/java/cn/nukkit/network/Network.java
#	src/main/java/cn/nukkit/network/RakNetInterface.java
According to GamePedia, quartz_bricks is 559. Leaving 41 free to allow expansion and custom blocks.
@joserobjr joserobjr changed the base branch from bleeding to master July 1, 2020 04:51
Copy link
Member Author

@joserobjr joserobjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine

@joserobjr joserobjr merged commit d2de81b into master Jul 1, 2020
@joserobjr joserobjr deleted the PN-115 branch July 1, 2020 07:15
@joserobjr joserobjr added Resolution: resolved The issue has been addressed or the request has been accepted and removed Status: Needs Testing The pull request looks good but needs to be tested a little more before being accepted labels Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: resolved The issue has been addressed or the request has been accepted Type: enhancement Enhancements and fixes to already existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.