temporarily add DCO check #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Jerry-Jinfeng-Guo
previously approved these changes
Jun 5, 2024
|
For other approved PRs, do we need to push empty commit to trigger the ci? |
that wouldn't be sufficient because the workflow wouldn't be there. merge with main would do the trick |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
merge queue build failed due to actions/runner-images#10001 |
Signed-off-by: Martijn Govers <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
temporarily remove clang cl from CI
Jerry-Jinfeng-Guo
approved these changes
Jun 5, 2024
|
This was referenced Jun 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary workaround to do the DCO check ourselves because the DCO app is stuck (see dcoapp/app#211 )
To be reverted in #626