-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] basic validation checks for tap regulator #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitbharambe
reviewed
Jun 4, 2024
nitbharambe
reviewed
Jun 4, 2024
Signed-off-by: Martijn Govers <[email protected]> resolve comments Signed-off-by: Martijn Govers <[email protected]> Update src/power_grid_model/validation/validation.py Signed-off-by: Martijn Govers <[email protected]> Co-authored-by: Nitish Bharambe <[email protected]> Signed-off-by: Martijn Govers <[email protected]> tmp Signed-off-by: Martijn Govers <[email protected]> tmp Signed-off-by: Martijn Govers <[email protected]>
mgovers
force-pushed
the
feature/basic-validation-check-tap-regulator
branch
from
June 4, 2024 13:28
88452ab
to
2dce7c9
Compare
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
stuck due to dcoapp/app#211 |
Signed-off-by: Nitish Bharambe <[email protected]>
Co-authored-by: Jerry Guo <[email protected]> Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
…ure/add-tap-regulator-data-validation-required-check
…-data-validation-required-check tap regulator data validation required check
Quality Gate passedIssues Measures |
Jerry-Jinfeng-Guo
approved these changes
Jun 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.