Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] basic validation checks for tap regulator #620

Merged
merged 10 commits into from
Jun 6, 2024

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Jun 4, 2024

No description provided.

@mgovers mgovers added the feature New feature or request label Jun 4, 2024
@mgovers mgovers requested a review from nitbharambe June 4, 2024 09:25
@mgovers mgovers self-assigned this Jun 4, 2024
@mgovers mgovers enabled auto-merge June 4, 2024 11:03
Signed-off-by: Martijn Govers <[email protected]>

resolve comments

Signed-off-by: Martijn Govers <[email protected]>

Update src/power_grid_model/validation/validation.py

Signed-off-by: Martijn Govers <[email protected]>

Co-authored-by: Nitish Bharambe <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>

tmp

Signed-off-by: Martijn Govers <[email protected]>

tmp

Signed-off-by: Martijn Govers <[email protected]>
@mgovers mgovers force-pushed the feature/basic-validation-check-tap-regulator branch from 88452ab to 2dce7c9 Compare June 4, 2024 13:28
@mgovers mgovers disabled auto-merge June 4, 2024 14:12
mgovers added 2 commits June 4, 2024 16:13
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
@mgovers
Copy link
Member Author

mgovers commented Jun 4, 2024

stuck due to dcoapp/app#211

Signed-off-by: Nitish Bharambe <[email protected]>
Co-authored-by: Jerry Guo <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
@mgovers mgovers enabled auto-merge June 5, 2024 08:38
mgovers and others added 5 commits June 5, 2024 10:57
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
…ure/add-tap-regulator-data-validation-required-check
…-data-validation-required-check

tap regulator data validation required check
Copy link

sonarqubecloud bot commented Jun 6, 2024

@mgovers mgovers added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit 7ec3f41 Jun 6, 2024
25 checks passed
@mgovers mgovers deleted the feature/basic-validation-check-tap-regulator branch June 6, 2024 07:31
@mgovers mgovers mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants