Update s3.go to enable content-md5 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add call to minio putObjectOptions.SendContentMd5 to enable sending of content-md5 header for end-to-end integrity checking.
|
LGTM. Thank you for this :) I'll make a v0.2.6 release now. You can open a PR for lightningstream with the upgrade so you have full credits! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #49
If my understanding is correct, the MiniO library actually does most of the heavy-lifting for you so all that should be needed is setting the
putObjectOptions.SendContentMd5flag and the MinIO library will automagically do the rest for you, which makes enabling this enhancement pretty easy.I have worked on the assumption that the desired default behaviour is to enable sending Content-MD5 since doing so has significant benefits (upload integrity) and minimal downsides (on modern processors calculating MD5 should not be a demanding task). But I have attempted to add a way for people to disable sending it if they feel they need to.
N.B. I am not overly familiar with the
simpleblobcodebase so its possible I might have missed another section of code that needs to be "touched" but as I understand everything callsdoStore()in the end.