convertMinioError: stop shadowing minio error with os.ErrNotExist #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`convertMinioError` would ignore the actual error and return `os.ErrNotFound` when the StatusCode field of minio error is 404. Now, `os.ErrNotFound` and the minio error are wrapped together, allowing to propagate the original meaning of the error.
nvaatstra
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
LGTM; Tested within 2 clients that utilise Simpleblob and both now correctly report:
file does not exist: The specified bucket does not exist
When I try to access a non-existing bucket. Previously I received a misleading file does not exist error without the added context of the bucket not existing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convertMinioErrorwould ignore the actual error and returnos.ErrNotExistwhen the StatusCode field of minio error is 404.Now,
os.ErrNotExistand the minio error are wrapped together, allowing to propagate the original meaning of the error.