Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3: Handle errors returned by MinIO Client ListObjects #22

Merged
merged 4 commits into from
Jan 11, 2023

Conversation

nvaatstra
Copy link
Contributor

ListObjects() on the MinIO client returns a channel of minio.ObjectInfo. If a ListObjects operation fails, the channel will contain an ObjectInfo with an error in Err.

This PR adds a test to see if an ObjectInfo has an Err and if so, stops trying to process the object and returns the error.

@wojas wojas requested a review from ahouene January 6, 2023 14:27
@ahouene
Copy link
Contributor

ahouene commented Jan 10, 2023

Looks good to me!

@wojas wojas merged commit 8b71881 into PowerDNS:main Jan 11, 2023
@wojas wojas added this to the v0.2.1 milestone Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants