Skip to content

fix: modify commentaries#6

Closed
PotaaatozWRLD wants to merge 1 commit into
mainfrom
Axel
Closed

fix: modify commentaries#6
PotaaatozWRLD wants to merge 1 commit into
mainfrom
Axel

Conversation

@PotaaatozWRLD

@PotaaatozWRLD PotaaatozWRLD commented Feb 9, 2026

Copy link
Copy Markdown
Owner

Pull Request

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (code improvements without changing functionality)
  • Documentation update
  • Performance improvement
  • Test coverage improvement

Related Issues

Fixes #
Relates to #

Changes Made

Testing Performed

  • All existing tests pass (dotnet test)
  • New tests added for new functionality
  • Manual testing performed
  • Tested on Windows
  • Tested with different backup types (Full/Differential)
  • Tested with network paths (UNC)

Test Results

Example: 82/83 tests passing

Backward Compatibility

  • This change is backward compatible with previous versions
  • EasyLog.dll remains compatible (no breaking changes to signatures)
  • Existing configuration files still work
  • Log formats unchanged (JSON/XML)

Documentation

  • Code comments updated (XML documentation for public APIs)
  • README.md updated (if needed)
  • Release notes updated (if applicable)
  • User manual updated (if user-facing changes)

Code Quality Checklist

  • Code follows C# Microsoft conventions (PascalCase, camelCase, etc.)
  • No code duplication (DRY principle respected)
  • Functions are reasonably sized (<50 lines ideally)
  • All code and comments are in English
  • No hardcoded absolute paths (use %AppData% or relative paths)
  • Nullable reference types handled properly
  • Error handling implemented appropriately

Review Checklist

  • Self-review completed
  • No console warnings or errors
  • Code builds successfully
  • Coverage report checked (if applicable)
  • CodeQL security scan passed

Screenshots / Logs

Additional Notes

Reviewers: Please check that all checkboxes are completed before approving.

@PotaaatozWRLD

PotaaatozWRLD commented Feb 9, 2026

Copy link
Copy Markdown
Owner Author

Nul

@codecov

codecov Bot commented Feb 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

PotaaatozWRLD added a commit that referenced this pull request Feb 10, 2026
@PotaaatozWRLD
feat(v2.0): Add business software detection (Task #6)
deb26b7 
Implemented v2.0 requirement to prevent backups when business software is running.

Features:
- BusinessSoftwareDetector service with IsRunning(processName) method
- BackupService.ExecuteBackup() now accepts optional businessSoftwareName parameter
- Throws InvalidOperationException if business software detected
- Case-insensitive process name matching
- Handles .exe extension automatically

Tests (12 new tests, 123/124 passing):
- 8 unit tests for BusinessSoftwareDetector (null/empty/running/closed/case-insensitive)
- 4 integration tests for BackupService (exception when running, success when not running)
- All tests use CalculatorApp (Windows 10+) as proof of concept
- Backward compatible: null/empty businessSoftwareName allows backup to proceed

Related config:
- Uses AppConfig.GetBusinessSoftwareName() (added in Task #4)
- Default empty string means no detection (v1.0/v1.1 behavior)

Cahier des charges: v2.0 - Interdiction de lancer un travail si logiciel métier détecté
@github-actions github-actions Bot mentioned this pull request Feb 10, 2026
Merged
33 tasks
PotaaatozWRLD added a commit that referenced this pull request Feb 10, 2026
@PotaaatozWRLD
Merge pull request #14 from PotaaatozWRLD/Kenan
b045526 
feat(v2.0): Add business software detection (Task #6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PotaaatozWRLD @AxelR69