3589 breakdown #3782
Merged
3589 breakdown #3782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-breakdown * '3589-breakdown' of github.com:PostHog/posthog: test
paolodamico
reviewed
Apr 1, 2021
paolodamico
approved these changes
Apr 1, 2021
There was a problem hiding this comment.
One very minor comment, but lgtm! Also, I do think at some point it'll make sense to adjust this a tiny bit to make it more intuitive, but definitely an improvement for now.
Did a few nit adjustments & updated the UI to show more clarity around what's going on, show when all breakdown values are already loaded, and show a loading indicator when we're fetching more values.
This was referenced Apr 1, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please describe.
If this affects the frontend, include screenshots.
Checklist