feat: remove og lts recording storage #25945
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
commented
Nov 1, 2024
|
|
||
| recording.load_metadata() | ||
|
|
||
| if not recording.start_time or timezone.now() < recording.start_time + MINIMUM_AGE_FOR_RECORDING: | ||
| # Recording is too recent to be persisted. | ||
| # We can save the metadata as it is still useful for querying, but we can't move to S3 yet. | ||
| logger.info( |
There was a problem hiding this comment.
i've not looked at these logs in a year, let's remove them
pauldambra
commented
Nov 1, 2024
| return "/".join(path_parts) | ||
| elif version == "2023-08-01": | ||
| return self._build_session_blob_path(settings.OBJECT_STORAGE_SESSION_RECORDING_LTS_FOLDER) | ||
| def build_object_lts_path(self, version: Literal["2023-08-01"]) -> str: |
There was a problem hiding this comment.
this method name confused me even in the context of dealing with LTS storage -> rename
pauldambra
commented
Nov 1, 2024
Comment on lines
+101
to
+105
| assert object_storage_client().list_objects(OBJECT_STORAGE_BUCKET, blob_path) == [ | ||
| f"{blob_path}/a", | ||
| f"{blob_path}/b", | ||
| f"{blob_path}/c", | ||
| ] |
There was a problem hiding this comment.
my change at first broke this test but it failed elsewhere... added this assertion so that i got a meaningful failure
pauldambra
commented
Nov 1, 2024
| might_have_realtime = False | ||
| blob_prefix = recording.object_storage_path | ||
| blob_keys = object_storage.list_objects(cast(str, blob_prefix)) | ||
| might_have_realtime = False |
There was a problem hiding this comment.
there was a bug here, that we didn't set might_have_realtime as false for these recordings
good job it didn't take a year to spot it 🙈
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed the format we store recordings into the long term storage S3 bucket on 1st August 2023
Recordings last at most 1 year in LTS
So, they have all been deleted.
We can therefore delete all of the code to do with handling the old version
## TODO