Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: video for cypress tests #10493

Closed
wants to merge 4 commits into from
Closed

fix: video for cypress tests #10493

wants to merge 4 commits into from

Conversation

pauldambra
Copy link
Member

Problem

The copied example when upgrading to Cypress 10 included config to not capture videos 🤦

Changes

updates cypress and turns video back on

How did you test this code?

pushing the PR

@pauldambra pauldambra changed the title Fix/cypress videos fix: cypress videos Jun 24, 2022
@mariusandra mariusandra enabled auto-merge (squash) June 27, 2022 10:31
@pauldambra pauldambra disabled auto-merge July 1, 2022 09:14
@pauldambra pauldambra changed the title fix: cypress videos fix: video for cypress tests Jul 7, 2022
@pauldambra
Copy link
Member Author

Hmmmm cypress-io/cypress#18564

Multiple people reporting cypress performance issues post v8.x

In this PR we see execution time grow from 4 minutes to 16 minutes. In some cases longer causing the tests to be cancelled

@pauldambra
Copy link
Member Author

turning video on leads to a cascade of nonsense

very slow in electron causing failures
spec failures in chrome
different spec failures in firefox

@mariusandra I'd suggest that the videos aren't valuable enough for the effort to enable them

@pauldambra pauldambra closed this Jul 7, 2022
@mariusandra mariusandra deleted the fix/cypress-videos branch July 8, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant