-
Notifications
You must be signed in to change notification settings - Fork 669
feat: document new nuxt module #13190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 1 comment
edwinyjlim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Here's a PR to separate the installation for different Nuxt versions. Take a look
daibhin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make sure we update the docs in the onboarding too once we're happy with the public facing ones. Will leave it to @edwinyjlim to approve because I see he's already reviewed this
11caa5e to
916229d
Compare
edwinyjlim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great @ablaszkiewicz
I marked a bunch of nits:
- using
vfor versioning - source maps as two words
- no client and server side with no hyphen
- etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great @ablaszkiewicz
I marked a bunch of nits:
- using
vfor versioning - source maps as two words
- client and server side with no hyphen
- etc.
Changes
As we added official posthog nuxt module here, docs need some updates.
I updated 3 things:
/docs/libraries/nuxt-js- I added section for nuxt 3.7+ and provided example code which will get you up and running. That code does not focus on making automatic source maps generate and upload work. I added mini section which links to/docs/error-tracking/installation/nuxt- this contains in depth instructions on how to set it up in context of erroor tracking./docs/error-tracking/installation/nuxt- I moved everything we had into sectionNuxt 3.6 and belowand then added new sectionNuxt 3.7 and above- this is an in depth explanation about how to use that product in context of error tracking/docs/error-tracking/upload-source-maps/nuxt- I moved everything we had into sectionNuxt 3.6 and belowand then added new sectionNuxt 3.7 and above- this section links to/docs/error-tracking/installation/nuxtwhich contains in depth explanation.Checklist
vercel.json